src: rename --security-reverts to ...-revert#29153
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
It was called --security-revert prior to 12.x, but changed in nodejs#22490. See: nodejs/nodejs.org#2412 (comment)
nodejs-github-bot added the c++ 
addaleax approved these changes Aug 15, 2019
Member
addaleax left a comment
addaleax left a comment There was a problem hiding this comment.
Yeah, that looks like an accidental change… do we want to keep an alias so that this is not semver-major for now, i.e. AddAlias("--security-reverts", "--security-revert");?
addaleax added the cli 
cjihrig approved these changes Aug 15, 2019
richardlau approved these changes Aug 15, 2019
addaleax added the author ready 
Collaborator
nodejs-github-bot commented Aug 15, 2019
lpinca approved these changes Aug 15, 2019
BethGriggs approved these changes Aug 15, 2019
Collaborator
nodejs-github-bot commented Aug 15, 2019
Trott approved these changes Aug 16, 2019
trivikr approved these changes Aug 16, 2019
jasnell approved these changes Aug 16, 2019
Member
Trott commented Aug 17, 2019
Landed in 5dee17b |
Trott pushed a commit that referenced this pull request Aug 17, 2019
It was called --security-revert prior to 12.x, but changed in #22490. See: nodejs/nodejs.org#2412 (comment) PR-URL: #29153 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Aug 19, 2019
It was called --security-revert prior to 12.x, but changed in #22490. See: nodejs/nodejs.org#2412 (comment) PR-URL: #29153 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Aug 20, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was called --security-revert prior to 12.x, but changed in
#22490.
See:
nodejs/nodejs.org#2412 (comment)
@addaleax good idea?
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes