net: use callback to properly propagate error#29178
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The socket will be destroyed upstream through the proper error flow.
lpinca approved these changes Aug 18, 2019
Collaborator
nodejs-github-bot commented Aug 18, 2019
jasnell approved these changes Aug 19, 2019
Collaborator
nodejs-github-bot commented Aug 19, 2019
Collaborator
nodejs-github-bot commented Aug 19, 2019
Member
Out of extra caution.... CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1968/ (queued) |
Member
Trott commented Aug 20, 2019
Landed in cc7cec2 |
Trott pushed a commit that referenced this pull request Aug 20, 2019
The socket will be destroyed upstream through the proper error flow. PR-URL: #29178 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Aug 20, 2019
The socket will be destroyed upstream through the proper error flow. PR-URL: #29178 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Aug 20, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The socket will be destroyed upstream through the proper error
flow.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes