lib,src,doc: remove usage of events.EventEmitter#2921
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The `events` module already exports `EventEmitter` constructor function So, we don't have to use `events.EventEmitter` to access it. Refer: nodejs#2896
thefourtheye added doc 
lib/_http_server.js Outdated
Contributor
There was a problem hiding this comment.
maybe var obj = new EventEmitter();?
The `events` module already exports `EventEmitter` constructor function So, we don't have to use `events.EventEmitter` to access it. Refer: nodejs#2896
thefourtheyeforce-pushed the events-eventemitter-usage branch 2 times, most recently from 742a9ad to 705ff31Compare
ContributorAuthor
thefourtheye commented Sep 19, 2015
Removing the test changes, after a lengthy discussion with @brendanashworth ;-) |
thefourtheye changed the title 
Contributor
silverwind commented Sep 22, 2015
Contributor
silverwind commented Sep 22, 2015
LGTM |
1 similar comment
Member
targos commented Sep 22, 2015
LGTM |
thefourtheye added a commit that referenced this pull request Sep 22, 2015
The `events` module already exports `EventEmitter` constructor function So, we don't have to use `events.EventEmitter` to access it. Refer: #2896 PR-URL: #2921 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
thefourtheye added a commit that referenced this pull request Sep 22, 2015
The `events` module already exports `EventEmitter` constructor function So, we don't have to use `events.EventEmitter` to access it. Refer: #2896 PR-URL: #2921 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
ContributorAuthor
thefourtheye commented Sep 22, 2015
thefourtheye added a commit that referenced this pull request Sep 22, 2015
The `events` module already exports `EventEmitter` constructor function So, we don't have to use `events.EventEmitter` to access it. Refer: #2896 PR-URL: #2921 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
thefourtheye added a commit that referenced this pull request Sep 22, 2015
The `events` module already exports `EventEmitter` constructor function So, we don't have to use `events.EventEmitter` to access it. Refer: #2896 PR-URL: #2921 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Closed
stojanovic added a commit to stojanovic/koa that referenced this pull request Oct 24, 2015
The 'events' module already exports 'EventEmitter' constructor function - nodejs/node#2921
This was referenced Nov 11, 2015
2 tasks
truedev0127 added a commit to truedev0127/koa that referenced this pull request Dec 22, 2025
The 'events' module already exports 'EventEmitter' constructor function - nodejs/node#2921
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
eventsmodule already exportsEventEmitterconstructor functionSo, we don't have to use
events.EventEmitterto access it.Refer: #2896
cc @silverwind@evanlucas