stream: simplify isUint8Array helper#29514
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The fallback code is no longer used when exporting to readable-stream. Refs: nodejs#29475
nodejs-github-bot added the stream 
benjamingr approved these changes Sep 9, 2019
trivikr approved these changes Sep 9, 2019
devnexen approved these changes Sep 10, 2019
cjihrig approved these changes Sep 10, 2019
lpinca approved these changes Sep 11, 2019
jasnell approved these changes Sep 11, 2019
Collaborator
nodejs-github-bot commented Sep 12, 2019
Trott added the author ready 
gengjiawen approved these changes Sep 12, 2019
Member
mcollina commented Sep 12, 2019
Landed in a33aa92 |
mcollina pushed a commit that referenced this pull request Sep 12, 2019
The fallback code is no longer used when exporting to readable-stream. Refs: #29475 PR-URL: #29514 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
targos pushed a commit that referenced this pull request Sep 20, 2019
The fallback code is no longer used when exporting to readable-stream. Refs: #29475 PR-URL: #29514 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
The fallback code is no longer used when exporting to readable-stream. Refs: #29475 PR-URL: #29514 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
This was referenced Sep 25, 2019
lpinca added a commit to lpinca/node that referenced this pull request Oct 20, 2019
The fallback code is no longer used when exporting to readable-stream. Refs: nodejs#29514
Trott pushed a commit that referenced this pull request Oct 22, 2019
The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Nov 8, 2019
The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2019
The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041Fixes: #30040 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback code is no longer used when exporting to readable-stream.
Refs: #29475
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes