Skip to content

stream: remove ambiguous code#29664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ronag wants to merge 1 commit into from
Closed

stream: remove ambiguous code #29664

ronag wants to merge 1 commit into from

Conversation

@ronag
Copy link
Member

@ronagronag commented Sep 23, 2019•
edited
Loading

This cleans up some ambiguous code. I don't believe this actually causes any observable change of behaviour.

writable, readable is supposed to indicate the type of the stream, which does not change... this PR makes the code less confusing

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@mscdex
Copy link
Contributor

mscdex commented Sep 23, 2019

s/ambigious/ambiguous/ in commit message

@ronagronag changed the title stream: remove ambigious codestream: remove ambiguous codeSep 23, 2019
@ronag
Copy link
MemberAuthor

ronag commented Sep 23, 2019

Not sure what you meant. But I'm guess it's the misspelling. Fixed.

@ronagronag mentioned this pull request Sep 23, 2019
Closed
4 tasks
@ronag
Copy link
MemberAuthor

ronag commented Sep 23, 2019

@mcollina

mcollina
mcollina requested changes Sep 23, 2019
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @mafintosh

mcollina
mcollina approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

mcollina commented Sep 27, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3939/

JungMinu pushed a commit that referenced this pull request Sep 29, 2019
@ronag@JungMinu
stream: remove ambiguous code
ce62e96
PR-URL: #29664 Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@JungMinu
Copy link
Member

JungMinu commented Sep 29, 2019

Landed in ce62e96

@BridgeARBridgeAR added backport-requested-v12.x stream Issues and PRs related to the stream subsystem. labels Oct 9, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Oct 9, 2019

@ronag I guess this depends on other PRs that need backporting first? This currently causes conflicts that are not obvious to resolve. Would you be so kind and check if other PRs need backporting first and add that as well / open a backport if you think that's useful here?

@ronag
Copy link
MemberAuthor

ronag commented Oct 9, 2019•
edited
Loading

This is probably about to be reverted in #29717 (comment).

I will look into backporting this if/when this becomes relevant again.

@MylesBorins
Copy link
Contributor

MylesBorins commented Jan 10, 2020

quick ping re: backport

ronag added a commit to nxtedition/node that referenced this pull request Jan 18, 2020
@ronag
stream: remove ambiguous code
ba74fd8
PR-URL: nodejs#29664 Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
sxa pushed a commit to sxa/node that referenced this pull request Jan 24, 2020
@ronag
[v12.x backport] stream: remove ambiguous code
8ff774e
PR-URL: nodejs#29664 Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@sxa
Copy link
Member

sxa commented Jan 24, 2020

@MylesBorins In view of 8c60685#diff-009356850b536cab27b019ba8ad15e72 are you sure this should be backported?

@MylesBorins
Copy link
Contributor

MylesBorins commented Jan 24, 2020

Seems like it shouldn't

@kissofirekissofire mentioned this pull request Feb 25, 2021
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Feb 25, 2021
Open
@ron-a20ron-a20 mentioned this pull request Feb 26, 2021
Open
@sitedatasitedata mentioned this pull request Feb 26, 2021
Open
@meghasfdcmeghasfdc mentioned this pull request Feb 26, 2021
Open
@137717unity137717unity mentioned this pull request Feb 26, 2021
Open
@RednickleRednickle mentioned this pull request Feb 26, 2021
Open
This was referenced May 5, 2021
Open
Closed
Closed
Open
Open
@snyk-botsnyk-bot mentioned this pull request May 26, 2021
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Oct 30, 2022
Open
@137717unity137717unity mentioned this pull request Oct 30, 2022
Open
@molllyn1molllyn1 mentioned this pull request Oct 30, 2022
Open
@kissofirekissofire mentioned this pull request Oct 30, 2022
Open
@wedataintelligencewedataintelligence mentioned this pull request Oct 30, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 31, 2022
Open
@ron-a20ron-a20 mentioned this pull request Oct 31, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 31, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Nov 10, 2022
Open
@kissofirekissofire mentioned this pull request Dec 6, 2023
Open
@137717unity137717unity mentioned this pull request Dec 6, 2023
Open
@ron-a20ron-a20 mentioned this pull request Dec 6, 2023
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Dec 6, 2023
Open
@wedataintelligencewedataintelligence mentioned this pull request Dec 7, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@JungMinuJungMinuJungMinu approved these changes

Assignees

No one assigned

Labels

streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ronag@mscdex@mcollina@JungMinu@BridgeAR@MylesBorins@sxa