worker: fix process._fatalException return type#29706
Closed
+46 −19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This makes sure `process._fatalException()` returns a boolean when run inside of a worker.
addaleax approved these changes Sep 25, 2019
devnexen approved these changes Sep 25, 2019
Collaborator
nodejs-github-bot commented Sep 25, 2019
jasnell approved these changes Sep 25, 2019
lpinca approved these changes Sep 25, 2019
BridgeAR added author ready Collaborator
nodejs-github-bot commented Sep 25, 2019
JungMinu approved these changes Sep 26, 2019
Member
Trott commented Sep 27, 2019
Landed in aea9a0f |
Trott pushed a commit that referenced this pull request Sep 27, 2019
This makes sure `process._fatalException()` returns a boolean when run inside of a worker. PR-URL: #29706 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
targos pushed a commit that referenced this pull request Oct 1, 2019
This makes sure `process._fatalException()` returns a boolean when run inside of a worker. PR-URL: #29706 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
This was referenced May 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure
process._fatalException()returns a boolean whenrun inside of a worker.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes