doc: clarify --pending-deprecation effects on Buffer() usage#29769
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added deprecations 4 tasks
MemberAuthor
Trott commented Sep 30, 2019
addaleax approved these changes Sep 30, 2019
cjihrig approved these changes Sep 30, 2019
Contributor
lholmquist commented Sep 30, 2019
+1 I'll close the PR i opened #29725 in favor of this one. I didn't realize there was more to the flag for this particular example |
jasnell approved these changes Sep 30, 2019
lpinca approved these changes Sep 30, 2019
lholmquist approved these changes Oct 1, 2019
Trott added the author ready 
BridgeAR approved these changes Oct 1, 2019
MemberAuthor
Trott commented Oct 2, 2019
Landed in 344c5c4 |
Trott added a commit that referenced this pull request Oct 2, 2019
Refs: #29725 (comment) PR-URL: #29769 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit that referenced this pull request Oct 9, 2019
Refs: #29725 (comment) PR-URL: #29769 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
This was referenced May 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #29725
Refs: #29725 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes