Skip to content

vm: add Synthetic modules#29864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
devsnek wants to merge 1 commit into from
Closed

vm: add Synthetic modules #29864

devsnek wants to merge 1 commit into from

Conversation

@devsnek
Copy link
Member

@devsnekdevsnek commented Oct 6, 2019

  • Refactor vm.SourceTextModule (again)
  • Add vm.Module abstract superclass
  • Add vm.SyntheticModule

Refs: https://heycam.github.io/webidl/#synthetic-module-records

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@devsnekdevsnek added vm Issues and PRs related to the vm subsystem. experimental Issues and PRs related to experimental features. esm Issues and PRs related to the ECMAScript Modules implementation. labels Oct 6, 2019
@nodejs-github-botnodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 6, 2019
@devsnek
Copy link
MemberAuthor

devsnek commented Oct 6, 2019

cc @vsemozhetbyt

@devsnekdevsnekforce-pushed the more-vm-shenanigans branch from d3a8f85 to 99f84f0CompareOctober 6, 2019 21:12
@devsnekdevsnek removed the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 6, 2019
@devsnekdevsnekforce-pushed the more-vm-shenanigans branch 3 times, most recently from c396c6e to 20ee326CompareOctober 7, 2019 19:07
vsemozhetbyt
vsemozhetbyt reviewed Oct 7, 2019
View reviewed changes
guybedford
guybedford approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@guybedfordguybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

addaleax
addaleax reviewed Oct 7, 2019
View reviewed changes
targos
targos reviewed Oct 8, 2019
View reviewed changes
targos
targos reviewed Oct 8, 2019
View reviewed changes
doc/api/vm.md Outdated
Copy link
Member

@targostargosOct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if name was not listed in exportNames?

Copy link
MemberAuthor

@devsnekdevsnekOct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the spec says a ReferenceError is thrown but V8 currently aborts. I posted about it on the bug tracker yesterday so hopefully it will be fixed soon.

@devsnekdevsnekforce-pushed the more-vm-shenanigans branch 3 times, most recently from 3b8872d to 380891bCompareOctober 12, 2019 07:11
@devsnek
vm: add Synthetic modules
baf46f6
- Refactor vm.SourceTextModule (again) - Add vm.Module abstract superclass - Add vm.SyntheticModule Refs: https://heycam.github.io/webidl/#synthetic-module-records
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 12, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25988/

@Trott
Copy link
Member

Trott commented Oct 13, 2019

@nodejs/vm

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 13, 2019
Trott pushed a commit that referenced this pull request Oct 14, 2019
@devsnek@Trott
vm: add Synthetic modules
f9caee9
- Refactor vm.SourceTextModule (again) - Add vm.Module abstract superclass - Add vm.SyntheticModule Refs: https://heycam.github.io/webidl/#synthetic-module-records PR-URL: #29864 Reviewed-By: Guy Bedford <[email protected]>
@Trott
Copy link
Member

Trott commented Oct 14, 2019

Landed in f9caee9

@TrottTrott closed this Oct 14, 2019
@devsnekdevsnek deleted the more-vm-shenanigans branch October 14, 2019 21:51
@molllyn1molllyn1 mentioned this pull request Nov 5, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Nov 5, 2022
Open
@baby636baby636 mentioned this pull request Nov 5, 2022
Open
@ron-a20ron-a20 mentioned this pull request Nov 5, 2022
Open
@wedataintelligencewedataintelligence mentioned this pull request Nov 5, 2022
Open
@kissofirekissofire mentioned this pull request Nov 5, 2022
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Dec 25, 2022
Open
@wedataintelligencewedataintelligence mentioned this pull request Dec 25, 2022
Open
@kissofirekissofire mentioned this pull request Dec 25, 2022
Open
@molllyn1molllyn1 mentioned this pull request Dec 26, 2022
Open
@137717unity137717unity mentioned this pull request Dec 26, 2022
Open
@baby636baby636 mentioned this pull request Dec 26, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Dec 26, 2022
Open
@ron-a20ron-a20 mentioned this pull request Oct 1, 2023
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Oct 1, 2023
Open
@kissofirekissofire mentioned this pull request Oct 1, 2023
Open
@wedataintelligencewedataintelligence mentioned this pull request Oct 2, 2023
Open
@molllyn1molllyn1 mentioned this pull request Oct 2, 2023
Open
@137717unity137717unity mentioned this pull request Oct 2, 2023
Open
@baby636baby636 mentioned this pull request Oct 2, 2023
Open
@baby636baby636 mentioned this pull request Jan 2, 2024
Open
@ron-a20ron-a20 mentioned this pull request Jan 9, 2024
Open
@kissofirekissofire mentioned this pull request Jan 9, 2024
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Jan 9, 2024
Open
@molllyn1molllyn1 mentioned this pull request Jan 9, 2024
Open
@137717unity137717unity mentioned this pull request Jan 9, 2024
Open
@wedataintelligencewedataintelligence mentioned this pull request Jan 9, 2024
Open
@baby636baby636 mentioned this pull request Jan 9, 2024
Open
@baby636baby636 mentioned this pull request Mar 19, 2024
Open
@baby636baby636 mentioned this pull request Mar 27, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guybedfordguybedfordguybedford approved these changes

@addaleaxaddaleaxaddaleax left review comments

@targostargostargos left review comments

@joyeecheungjoyeecheungAwaiting requested review from joyeecheung

+2 more reviewers

@JamesernatorJamesernatorJamesernator left review comments

@vsemozhetbytvsemozhetbytvsemozhetbyt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.esmIssues and PRs related to the ECMAScript Modules implementation.experimentalIssues and PRs related to experimental features.semver-minorPRs that contain new features and should be released in the next minor version.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@devsnek@nodejs-github-bot@Trott@guybedford@addaleax@targos@joyeecheung@Jamesernator@vsemozhetbyt