src: refine maps parsing for large pages#29973
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ 
devnexen approved these changes Oct 14, 2019
Contributor
devnexen commented Oct 14, 2019
nit: I would make clearer it is Linux even though map implies means /proc reading but no forcing here :-) |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Multiple sections may be marked as "r-xp" and with the executable's path. We use the location of the `__nodetext` symbol added by the linker script to ensure that the range we retrieve from the maps file does indeed contain the Node.js text section. Thanks to Suresh Srinivas <[email protected]>!
gabrielschulhofforce-pushed the fix-largepages-section-misread branch from 4937566 to ecea44cCompare
ContributorAuthor
gabrielschulhof commented Oct 15, 2019
@bnoordhuis I fixed the comparison and moved the whole thing to |
bnoordhuis approved these changes Oct 15, 2019
jasnell approved these changes Oct 15, 2019
Collaborator
nodejs-github-bot commented Oct 16, 2019
Trott added the author ready gabrielschulhof pushed a commit that referenced this pull request Oct 16, 2019
Multiple sections may be marked as "r-xp" and with the executable's path. We use the location of the `__nodetext` symbol added by the linker script to ensure that the range we retrieve from the maps file does indeed contain the Node.js text section. Thanks to Suresh Srinivas <[email protected]>! PR-URL: #29973 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
ContributorAuthor
gabrielschulhof commented Oct 16, 2019
Landed in 1599aeb. |
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
Multiple sections may be marked as "r-xp" and with the executable's path. We use the location of the `__nodetext` symbol added by the linker script to ensure that the range we retrieve from the maps file does indeed contain the Node.js text section. Thanks to Suresh Srinivas <[email protected]>! PR-URL: #29973 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
Multiple sections may be marked as "r-xp" and with the executable's path. We use the location of the `__nodetext` symbol added by the linker script to ensure that the range we retrieve from the maps file does indeed contain the Node.js text section. Thanks to Suresh Srinivas <[email protected]>! PR-URL: #29973 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
Merged
ContributorAuthor
gabrielschulhof commented Nov 1, 2019
@BethGriggs currently this patch applies cleanly to v12.x-staging after the previous patch (#29914). May it please be backported? |
targos pushed a commit that referenced this pull request Nov 8, 2019
Multiple sections may be marked as "r-xp" and with the executable's path. We use the location of the `__nodetext` symbol added by the linker script to ensure that the range we retrieve from the maps file does indeed contain the Node.js text section. Thanks to Suresh Srinivas <[email protected]>! PR-URL: #29973 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
Multiple sections may be marked as "r-xp" and with the executable's path. We use the location of the `__nodetext` symbol added by the linker script to ensure that the range we retrieve from the maps file does indeed contain the Node.js text section. Thanks to Suresh Srinivas <[email protected]>! PR-URL: #29973 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Mar 6, 2020
Multiple sections may be marked as "r-xp" and with the executable's path. We use the location of the `__nodetext` symbol added by the linker script to ensure that the range we retrieve from the maps file does indeed contain the Node.js text section. Thanks to Suresh Srinivas <[email protected]>! PR-URL: nodejs#29973 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple sections may be marked as "r-xp" and with the executable's
path. We use the location of the
__nodetextsymbol added by the linkerscript to ensure that the range we retrieve from the maps file does
indeed contain the Node.js text section.
Thanks to @suresh-srinivas!
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes