v8: let Object.defineProperty work with process.env#2999
Uh oh!
There was an error while loading. Please reload this page.
Conversation
bnoordhuis commented Sep 22, 2015
For posterity, that CL landed in v8/v8@fa3e6c0 and doesn't touch src/runtime/runtime-object.cc. I'm a bit hesitant to land this PR. The changes to runtime-object.cc don't look obviously correct to me. /cc @nodejs/build - can we have an option to run the V8 test suite on the CI as well? |
ChALkeR added v8 engine 
Fishrock123 commented Oct 19, 2015
Is this related to #3375? cc @trevnorris? |
trevnorris commented Oct 19, 2015
@Fishrock123 Don't believe so. |
ChALkeR commented Oct 21, 2015
The question is: will there be another 3.3.x release? |
rvagg commented Oct 22, 2015
Last 3.x release scheduled @ #3465, if someone really wants this in then you'll have to work hard at it. If @bnoordhuis is not happy with the look of it then I'd not be hopeful. /cc @nodejs/v8 - anyone brave enough to sign off on this? |
ChALkeR commented Jan 27, 2016
There will be no new 3.x releases, per #3465 (comment). |
[skip ci] ## 1.0.0 (2024-12-20) ### ⚠ BREAKING CHANGES * drop Node.js < 18.19.0 support part of eggjs/egg#3644eggjs/egg#5257 ### Features * add isMocked method to check if the member of the object is mocked ([986493c](986493c)) * reset package ([6779edb](6779edb)) * support cjs and esm both by tshy ([#2](#2)) ([49d3982](49d3982)) * support mock prop with getter setter ([#4](#4)) ([0ba2ae2](0ba2ae2)) ### Bug Fixes * can't redefine process.env when node<4 ([7de27b7](7de27b7)), closes [nodejs/node#2999](nodejs/node#2999) * clear mock cache when restore ([790b26c](790b26c)) * hasOwnProperty not found ([5e40063](5e40063)) * muk can mock accessor descriptor now ([73001d7](73001d7)) * should check process.env ([1cefede](1cefede))
7 participants
This fixes#2998.
This is only a back port to v3.x since the bug will not emerge in v4.x. It turned out that the v8 team encountered a similar bug regarding
window.localStoragein Chrome and landed a patch in Jun which is consequently applied into Node 4.x.https://codereview.chromium.org/1180073002
However the patch is too big to back port to v3.x. I made a minimal version and therefore come this PR.