Skip to content

deps: upgrade to libuv 1.33.1#29996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cjihrig merged 1 commit into from
Oct 20, 2019
Merged

deps: upgrade to libuv 1.33.1 #29996

cjihrig merged 1 commit into from
Oct 20, 2019

Conversation

@cjihrig
Copy link
Contributor

@cjihrigcjihrig commented Oct 16, 2019

Notable changes:

  • uv_random() has been added.
  • More work to read those pesky Windows environment variables.
  • Several build fixes for Tier 3 platforms (Android, NetBSD, OpenBSD, Haiku).
  • Stop using fsevents to watch files (using kqueue again).
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Oct 16, 2019
richardlau
richardlau approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@richardlaurichardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

trivikr
trivikr approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@trivikrtrivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 18, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26091/

@cjihrig
Copy link
ContributorAuthor

cjihrig commented Oct 18, 2019

CI failures look to be libuv/libuv#2522. I'm adding the blocked label in the interim.

@cjihrigcjihrig added the blocked PRs that are blocked by other issues or PRs. label Oct 18, 2019
@bnoordhuisbnoordhuis mentioned this pull request Oct 19, 2019
Closed
@cjihrigcjihrig changed the title deps: upgrade to libuv 1.33.0deps: upgrade to libuv 1.33.1Oct 19, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26114/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 19, 2019•
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/26115/ 💚

@cjihrigcjihrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels Oct 19, 2019
@cjihrig
deps: upgrade to libuv 1.33.1
7d433a9
Notable changes: - uv_random() has been added. - More work to read those pesky Windows environment variables. - Several build fixes for Tier 3 platforms (Android, NetBSD, OpenBSD, Haiku). - Stop using fsevents to watch files (using kqueue again). PR-URL: nodejs#29996 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
@cjihrigcjihrig merged commit 7d433a9 into nodejs:masterOct 20, 2019
@cjihrigcjihrig deleted the libuv branch October 20, 2019 15:14
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
@cjihrig@MylesBorins
deps: upgrade to libuv 1.33.1
b87e0d4
Notable changes: - uv_random() has been added. - More work to read those pesky Windows environment variables. - Several build fixes for Tier 3 platforms (Android, NetBSD, OpenBSD, Haiku). - Stop using fsevents to watch files (using kqueue again). PR-URL: #29996 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
@cjihrig@MylesBorins
deps: upgrade to libuv 1.33.1
9d332ab
Notable changes: - uv_random() has been added. - More work to read those pesky Windows environment variables. - Several build fixes for Tier 3 platforms (Android, NetBSD, OpenBSD, Haiku). - Stop using fsevents to watch files (using kqueue again). PR-URL: #29996 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Oct 23, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@cjihrig@targos
deps: upgrade to libuv 1.33.1
9d00b67
Notable changes: - uv_random() has been added. - More work to read those pesky Windows environment variables. - Several build fixes for Tier 3 platforms (Android, NetBSD, OpenBSD, Haiku). - Stop using fsevents to watch files (using kqueue again). PR-URL: #29996 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@cjihrig@targos
deps: upgrade to libuv 1.33.1
78f6327
Notable changes: - uv_random() has been added. - More work to read those pesky Windows environment variables. - Several build fixes for Tier 3 platforms (Android, NetBSD, OpenBSD, Haiku). - Stop using fsevents to watch files (using kqueue again). PR-URL: #29996 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
@targostargos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@cjihrig@targos
deps: upgrade to libuv 1.33.1
2764567
Notable changes: - uv_random() has been added. - More work to read those pesky Windows environment variables. - Several build fixes for Tier 3 platforms (Android, NetBSD, OpenBSD, Haiku). - Stop using fsevents to watch files (using kqueue again). PR-URL: #29996 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
BethGriggs pushed a commit to BethGriggs/node that referenced this pull request Feb 26, 2020
@cjihrig@BethGriggs
deps: upgrade to libuv 1.33.1
3d098e3
Notable changes: - uv_random() has been added. - More work to read those pesky Windows environment variables. - Several build fixes for Tier 3 platforms (Android, NetBSD, OpenBSD, Haiku). - Stop using fsevents to watch files (using kqueue again). PR-URL: nodejs#29996 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
BethGriggs pushed a commit that referenced this pull request Mar 2, 2020
@cjihrig@BethGriggs
deps: upgrade to libuv 1.33.1
6826ef0
Notable changes: - uv_random() has been added. - More work to read those pesky Windows environment variables. - Several build fixes for Tier 3 platforms (Android, NetBSD, OpenBSD, Haiku). - Stop using fsevents to watch files (using kqueue again). PR-URL: #29996 Backport-PR-URL: #31969 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Mar 12, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@gengjiawengengjiawengengjiawen approved these changes

@richardlaurichardlaurichardlau approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

@trivikrtrivikrtrivikr approved these changes

+1 more reviewer

@devnexendevnexendevnexen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.libuvIssues and PRs related to the libuv dependency or the uv binding.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@cjihrig@nodejs-github-bot@jasnell@addaleax@gengjiawen@devnexen@richardlau@gireeshpunathil@trivikr