Skip to content

src: remove unused iomanip include#30004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danbev wants to merge 1 commit into from
Closed

src: remove unused iomanip include #30004

danbev wants to merge 1 commit into from

Conversation

@danbev
Copy link
Contributor

@danbevdanbev commented Oct 17, 2019

This commit removes the include of the IO manipulators header as I can't
find that it is used anywhere.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
src: remove unused iomanip include
e5a735a
This commit removes the include of the IO manipulators header as I can't find that it is used anywhere.
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report. labels Oct 17, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26075/

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Oct 17, 2019

I think it was used for setfill which was subsequently removed.

@richardlaurichardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 17, 2019
danbev added a commit that referenced this pull request Oct 21, 2019
@danbev
src: remove unused iomanip include
a5bab21
This commit removes the include of the IO manipulators header as I can't find that it is used anywhere. PR-URL: #30004 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@danbev
Copy link
ContributorAuthor

danbev commented Oct 21, 2019

Landed in a5bab21.

@danbevdanbev closed this Oct 21, 2019
@danbevdanbev deleted the report_unused_iomanip branch October 21, 2019 04:01
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
@danbev@MylesBorins
src: remove unused iomanip include
564e1bd
This commit removes the include of the IO manipulators header as I can't find that it is used anywhere. PR-URL: #30004 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
@danbev@MylesBorins
src: remove unused iomanip include
9721440
This commit removes the include of the IO manipulators header as I can't find that it is used anywhere. PR-URL: #30004 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Oct 23, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@danbev@targos
src: remove unused iomanip include
daf3ca4
This commit removes the include of the IO manipulators header as I can't find that it is used anywhere. PR-URL: #30004 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@danbev@targos
src: remove unused iomanip include
c50c6ee
This commit removes the include of the IO manipulators header as I can't find that it is used anywhere. PR-URL: #30004 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@targostargos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@danbev@targos
src: remove unused iomanip include
6269a3c
This commit removes the include of the IO manipulators header as I can't find that it is used anywhere. PR-URL: #30004 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

@richardlaurichardlaurichardlau approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

+1 more reviewer

@devnexendevnexendevnexen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.reportIssues and PRs related to process.report.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@danbev@nodejs-github-bot@gireeshpunathil@addaleax@lpinca@cjihrig@devnexen@richardlau