build: default Windows build to Visual Studio 2019#30022
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added build 
MemberAuthor
targos commented Oct 18, 2019
@nodejs/build Are there already plans to add VS 2019 to our CI? |
Member
joaocgreis commented Oct 18, 2019
@targos Can you make VS2019 the default? Leave VS2017 as it was, but move VS2019 above and change it to fallback to VS2017 if not found. We've always preferred the latest version, I believe we should keep doing that. I will add VS2019 machines to CI, and plan to start using it to build releases on Node v14. |
Member
gengjiawen commented Oct 18, 2019
Can you add |
Building and testing Node.js with Visual Studio 2019 is now working as expected. Fallback to VS 2017 if VS 2019 was not found. Fixes: nodejs#27214
MemberAuthor
targos commented Oct 18, 2019
@joaocgreis@gengjiawen done 👍 |
Collaborator
nodejs-github-bot commented Oct 18, 2019
gengjiawen approved these changes Oct 18, 2019
Collaborator
nodejs-github-bot commented Oct 18, 2019
Uh oh!
There was an error while loading. Please reload this page.
targos changed the title 
richardlau approved these changes Oct 18, 2019
BethGriggs approved these changes Oct 18, 2019
MemberAuthor
targos commented Oct 20, 2019
Landed in b554214 |
targos added a commit that referenced this pull request Oct 20, 2019
Building and testing Node.js with Visual Studio 2019 is now working as expected. Fallback to VS 2017 if VS 2019 was not found. Fixes: #27214 PR-URL: #30022 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
Building and testing Node.js with Visual Studio 2019 is now working as expected. Fallback to VS 2017 if VS 2019 was not found. Fixes: #27214 PR-URL: #30022 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
Building and testing Node.js with Visual Studio 2019 is now working as expected. Fallback to VS 2017 if VS 2019 was not found. Fixes: #27214 PR-URL: #30022 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Merged
This was referenced Oct 25, 2019
richardlau added a commit to richardlau/node-1 that referenced this pull request Nov 5, 2019
When run in a Visual Studio 2017 command prompt the `VCINSTALLDIR` environment variable will be already set and is not cleared by the `tools/msvs/vswhere_usability_wrapper.cmd` utility when it fails to find Visual Studio 2019. This causes `vcbuild.bat` to incorrectly assume Visual Studio 2019 and generate an incompatible configuration. Clearing the value of `VCINSTALLDIR` before calling the utility fixes the detection logic. PR-URL: nodejs#30119Fixes: nodejs#30118 Refs: nodejs#30022 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: João Reis <[email protected]>
targos pushed a commit that referenced this pull request Nov 5, 2019
When run in a Visual Studio 2017 command prompt the `VCINSTALLDIR` environment variable will be already set and is not cleared by the `tools/msvs/vswhere_usability_wrapper.cmd` utility when it fails to find Visual Studio 2019. This causes `vcbuild.bat` to incorrectly assume Visual Studio 2019 and generate an incompatible configuration. Clearing the value of `VCINSTALLDIR` before calling the utility fixes the detection logic. PR-URL: #30119Fixes: #30118 Refs: #30022 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: João Reis <[email protected]>
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building and testing Node.js with Visual Studio 2019 is now working as
expected.
/cc @nodejs/platform-windows