Skip to content

https: client support for TLS keylog events#30053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sam-github wants to merge 1 commit into from
Closed

https: client support for TLS keylog events #30053

sam-github wants to merge 1 commit into from

Conversation

@sam-github
Copy link
Contributor

@sam-githubsam-github commented Oct 21, 2019

The keylog event is implemented on TLS sockets, but client HTTPS uses
TLS sockets managed by an agent, so accessing the underlying socket
before the TLS handshake completed was not possible. Note that server
HTTPS already supports the keylog event because it inherits from the TLS
server.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the http Issues or PRs related to the http subsystem. label Oct 21, 2019
mscdex
mscdex reviewed Oct 21, 2019
View reviewed changes
bnoordhuis
bnoordhuis reviewed Oct 22, 2019
View reviewed changes
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 22, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26148/

mscdex
mscdex reviewed Oct 22, 2019
View reviewed changes
lpinca
lpinca approved these changes Oct 22, 2019
View reviewed changes
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 22, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26153/

bnoordhuis
bnoordhuis approved these changes Oct 23, 2019
View reviewed changes
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 24, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26186/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26729/

@sam-github
https: client support for TLS keylog events
246e744
The keylog event is implemented on TLS sockets, but client HTTPS uses TLS sockets managed by an agent, so accessing the underlying socket before the TLS handshake completed was not possible. Note that server HTTPS already supports the keylog event because it inherits from the TLS server.
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26762/

@TrottTrott added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 20, 2019
@Trott
Copy link
Member

Trott commented Nov 20, 2019

Landed in b0cf62b

@TrottTrott closed this Nov 20, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 20, 2019
@sam-github@Trott
https: add client support for TLS keylog events
b0cf62b
The keylog event is implemented on TLS sockets, but client HTTPS uses TLS sockets managed by an agent, so accessing the underlying socket before the TLS handshake completed was not possible. Note that server HTTPS already supports the keylog event because it inherits from the TLS server. PR-URL: nodejs#30053 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
@sam-githubsam-github deleted the agent-keylog branch November 20, 2019 16:01
MylesBorins pushed a commit that referenced this pull request Nov 21, 2019
@sam-github@MylesBorins
https: add client support for TLS keylog events
f25b00a
The keylog event is implemented on TLS sockets, but client HTTPS uses TLS sockets managed by an agent, so accessing the underlying socket before the TLS handshake completed was not possible. Note that server HTTPS already supports the keylog event because it inherits from the TLS server. PR-URL: #30053 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
@BridgeARBridgeAR mentioned this pull request Nov 21, 2019
Merged
targos pushed a commit that referenced this pull request Jan 13, 2020
@sam-github@targos
https: add client support for TLS keylog events
dc521b0
The keylog event is implemented on TLS sockets, but client HTTPS uses TLS sockets managed by an agent, so accessing the underlying socket before the TLS handshake completed was not possible. Note that server HTTPS already supports the keylog event because it inherits from the TLS server. PR-URL: #30053 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Jan 15, 2020
Closed
@mildsunrise
Copy link
Contributor

mildsunrise commented Jan 30, 2020

Thanks for this change! 💙
@kolontsov With this and #30055, I think we can fully deprecate sslkeylog now

BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@sam-github@BethGriggs
https: add client support for TLS keylog events
dbee78c
The keylog event is implemented on TLS sockets, but client HTTPS uses TLS sockets managed by an agent, so accessing the underlying socket before the TLS handshake completed was not possible. Note that server HTTPS already supports the keylog event because it inherits from the TLS server. PR-URL: #30053 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

+1 more reviewer

@mscdexmscdexmscdex left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

httpIssues or PRs related to the http subsystem.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@sam-github@nodejs-github-bot@Trott@mildsunrise@mscdex@bnoordhuis@jasnell@addaleax@lpinca@cjihrig