src: do not use std::function for OnScopeLeave#30134
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
devsnek reviewed Oct 26, 2019
Uh oh!
There was an error while loading. Please reload this page.
devsnek approved these changes Oct 26, 2019
Uh oh!
There was an error while loading. Please reload this page.
cjihrig approved these changes Oct 26, 2019
Collaborator
nodejs-github-bot commented Oct 26, 2019
devnexen approved these changes Oct 26, 2019
addaleax added author ready 
MemberAuthor
addaleax commented Oct 26, 2019
Hm … looks like Windows doesn’t like this? I’ve added a move operator for the struct, I could imagine that MSVC added a copy operation when returning the value from the |
Collaborator
nodejs-github-bot commented Oct 26, 2019
fhinkel approved these changes Oct 26, 2019
addaleax added the author ready Collaborator
nodejs-github-bot commented Nov 1, 2019
Collaborator
nodejs-github-bot commented Nov 1, 2019
Collaborator
nodejs-github-bot commented Nov 4, 2019
Collaborator
nodejs-github-bot commented Nov 4, 2019
Collaborator
nodejs-github-bot commented Nov 5, 2019
jasnell approved these changes Nov 5, 2019
Collaborator
nodejs-github-bot commented Nov 5, 2019
Collaborator
nodejs-github-bot commented Nov 5, 2019
Collaborator
nodejs-github-bot commented Nov 6, 2019
Using `std::function` adds an extra layer of indirection, and in particular, heap allocations that are not necessary in our use case here.
addaleaxforce-pushed the onscopeleave-nostdfun branch from 552b639 to e3aa3b6CompareCollaborator
nodejs-github-bot commented Nov 6, 2019
Collaborator
nodejs-github-bot commented Nov 6, 2019
Collaborator
nodejs-github-bot commented Nov 6, 2019
Collaborator
nodejs-github-bot commented Nov 7, 2019
MemberAuthor
addaleax commented Nov 7, 2019
Landed in 6072e01 |
addaleax added a commit that referenced this pull request Nov 7, 2019
Using `std::function` adds an extra layer of indirection, and in particular, heap allocations that are not necessary in our use case here. PR-URL: #30134 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
Using `std::function` adds an extra layer of indirection, and in particular, heap allocations that are not necessary in our use case here. PR-URL: #30134 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Member
targos commented Dec 1, 2019
To land on v12.x, this should either wait for #29874, or be backported. |
MylesBorins pushed a commit that referenced this pull request Jan 10, 2020
Using `std::function` adds an extra layer of indirection, and in particular, heap allocations that are not necessary in our use case here. PR-URL: #30134 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
Using `std::function` adds an extra layer of indirection, and in particular, heap allocations that are not necessary in our use case here. PR-URL: #30134 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
std::functionadds an extra layer of indirection, and inparticular, heap allocations that are not necessary in our use case
here.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes