Skip to content

test: use arrow functions in async-hooks tests#30137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GaryGSC wants to merge 1 commit into from
Closed

test: use arrow functions in async-hooks tests #30137

GaryGSC wants to merge 1 commit into from

Conversation

@GaryGSC
Copy link
Contributor

@GaryGSCGaryGSC commented Oct 26, 2019

Convert all anonymous callback functions in test/async-hooks/*.js
to use arrow functions.

writing-tests.md states to use arrow functions when appropriate.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@GaryGSC
test: use arrow functions in async-hooks tests
0b9f68d
Convert all anonymous callback functions in `test/async-hooks/*.js` to use arrow functions. `writing-tests.md` states to use arrow functions when appropriate.
@nodejs-github-botnodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Oct 26, 2019
@GaryGSCGaryGSC changed the title test,async_hooks: use arrow functions in async-hooks teststest: use arrow functions in async-hooks testsOct 26, 2019
@GaryGSC

This comment has been minimized.

Sign in to view
@GaryGSC
Copy link
ContributorAuthor

GaryGSC commented Oct 28, 2019

make -j4 test passes.

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 30, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 30, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27223/

gireeshpunathil pushed a commit that referenced this pull request Dec 2, 2019
@GaryGSC@gireeshpunathil
test: use arrow functions in async-hooks tests
b27e240
Convert all anonymous callback functions in `test/async-hooks/*.js` to use arrow functions. `writing-tests.md` states to use arrow functions when appropriate. PR-URL: #30137 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@gireeshpunathil
Copy link
Member

gireeshpunathil commented Dec 2, 2019

landed in b27e240

@GaryGSCGaryGSC deleted the tests-async-hooks branch December 2, 2019 17:45
targos pushed a commit that referenced this pull request Dec 3, 2019
@GaryGSC@targos
test: use arrow functions in async-hooks tests
37c70ee
Convert all anonymous callback functions in `test/async-hooks/*.js` to use arrow functions. `writing-tests.md` states to use arrow functions when appropriate. PR-URL: #30137 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeARBridgeAR mentioned this pull request Dec 3, 2019
Merged
targos pushed a commit that referenced this pull request Dec 5, 2019
@GaryGSC@targos
test: use arrow functions in async-hooks tests
ed7dd93
Convert all anonymous callback functions in `test/async-hooks/*.js` to use arrow functions. `writing-tests.md` states to use arrow functions when appropriate. PR-URL: #30137 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@GaryGSC@MylesBorins
test: use arrow functions in async-hooks tests
6c6ffdd
Convert all anonymous callback functions in `test/async-hooks/*.js` to use arrow functions. `writing-tests.md` states to use arrow functions when appropriate. PR-URL: #30137 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Dec 31, 2019
@GaryGSC@BethGriggs
test: use arrow functions in async-hooks tests
5414047
Convert all anonymous callback functions in `test/async-hooks/*.js` to use arrow functions. `writing-tests.md` states to use arrow functions when appropriate. PR-URL: #30137 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

async_hooksIssues and PRs related to the async hooks subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GaryGSC@nodejs-github-bot@gireeshpunathil@addaleax@trivikr