tools: fix Python 3 syntax error in mac_tool.py#30146
Closed
+22 −30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cclauss requested review from Trott, bnoordhuis, codebytere, gengjiawen, richardlau, rvagg and sam-github
nodejs-github-bot added build cclauss added the python 
Member
bnoordhuis left a comment
bnoordhuis left a comment There was a problem hiding this comment.
You're making several changes. Can you split them into separate commits?
chrmoritz commented Oct 27, 2019
I think this would still need a backport of nodejs/node-gyp@a48f09b#diff-a486ea7ed25fd07c6c5a3aee31ed8308 to make it fully compatible with Python 3. |
ContributorAuthor
@chrmoritznodejs/node-gyp#1937 contains those changes and was already merged. You need to wait on the second gyp round trip which is blocked until nodejs/node-gyp#1935 lands and then is picked up by npm/cli and then reimported into nodejs/node /tools. Vendoring in dependencies is awesome. NOT!! |
This was referenced Oct 27, 2019
gengjiawen approved these changes Oct 29, 2019
codebytere approved these changes Oct 29, 2019
devnexen approved these changes Oct 29, 2019
Collaborator
nodejs-github-bot commented Oct 31, 2019
Collaborator
nodejs-github-bot commented Nov 1, 2019
Collaborator
nodejs-github-bot commented Nov 1, 2019
cclauss added a commit that referenced this pull request Nov 1, 2019
PR-URL: #30146 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: David Carlier <[email protected]>
ContributorAuthor
cclauss commented Nov 1, 2019
Landed in 9529c66 |
targos pushed a commit that referenced this pull request Nov 5, 2019
PR-URL: #30146 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: David Carlier <[email protected]>
targos pushed a commit that referenced this pull request Nov 8, 2019
PR-URL: #30146 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: David Carlier <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
PR-URL: #30146 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: David Carlier <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
PR-URL: #30146 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: David Carlier <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2019
PR-URL: #30146 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: David Carlier <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered at #30129 (comment)
Confirmed in #30143
https://portingguide.readthedocs.io/en/latest/syntax.html#tuple-unpacking-in-parameter-lists
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes