Skip to content

tools: use print() function in buildbot_run.py#30148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cclauss wants to merge 1 commit into from
Closed

tools: use print() function in buildbot_run.py #30148

cclauss wants to merge 1 commit into from

Conversation

@cclauss
Copy link
Contributor

@cclausscclauss commented Oct 27, 2019•
edited
Loading

Legacy print statements are syntax errors in Python 3 but
print() function works as expected in both Python 2 and 3.

Discovered via #30143

futurize -f libfuturize.fixes.fix_print_with_import -w tools/gyp/buildbot/buildbot_run.py

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Oct 27, 2019
@cclausscclauss added the python PRs and issues that require attention from people who are familiar with Python. label Oct 27, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 31, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26262/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 31, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26265/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 31, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26268/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 31, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26269/

cclauss added a commit that referenced this pull request Oct 31, 2019
@cclauss
tools: use print() function in buildbot_run.py
2d8307e
PR-URL: #30148 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@cclauss
Copy link
ContributorAuthor

cclauss commented Oct 31, 2019

Landed in 2d8307e

@cclausscclauss closed this Oct 31, 2019
@cclausscclauss deleted the fix-gyp-buildbot.py branch October 31, 2019 22:20
targos pushed a commit that referenced this pull request Nov 5, 2019
@cclauss@targos
tools: use print() function in buildbot_run.py
e2fb353
PR-URL: #30148 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@targostargos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@cclauss@targos
tools: use print() function in buildbot_run.py
d3f218e
PR-URL: #30148 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@cclauss@targos
tools: use print() function in buildbot_run.py
d0c779c
PR-URL: #30148 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
@cclauss@targos
tools: use print() function in buildbot_run.py
6838b6a
PR-URL: #30148 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@targostargos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@cclauss@targos
tools: use print() function in buildbot_run.py
87cb6b2
PR-URL: #30148 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

@lpincalpincalpinca approved these changes

@targostargostargos approved these changes

@cjihrigcjihrigcjihrig approved these changes

@gengjiawengengjiawengengjiawen approved these changes

@richardlaurichardlaurichardlau approved these changes

@trivikrtrivikrtrivikr approved these changes

@sam-githubsam-githubAwaiting requested review from sam-github

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.pythonPRs and issues that require attention from people who are familiar with Python.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@cclauss@nodejs-github-bot@Trott@lpinca@targos@cjihrig@gengjiawen@richardlau@trivikr