Skip to content

Conversation

@pmq20
Copy link
Contributor

  • reglar -> regular
  • is -> are
  • comment on the right indent level on "Need llvm_version..."

@pmq20pmq20force-pushed the minqi-pan-sep-23-2 branch 2 times, most recently from 85ed176 to 1df40f3CompareSeptember 23, 2015 04:06
@brendanashworthbrendanashworth added the build Issues and PRs related to build files or the CI. label Sep 23, 2015
@targos
Copy link
Member

Changes LGTM.
The commit message should have "build" as subsystem

@pmq20pmq20 changed the title configure: fix typofix some typo inside configure scriptSep 23, 2015
@pmq20pmq20 changed the title fix some typo inside configure scriptfix some typos inside the configure scriptSep 23, 2015
@pmq20
Copy link
ContributorAuthor

changed commit message to "build" as subsystem.

@silverwind
Copy link
Contributor

LGTM

silverwind pushed a commit that referenced this pull request Sep 23, 2015
PR-URL: #3016 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
@silverwind
Copy link
Contributor

Thanks, landed in d0d4877.

Fishrock123 pushed a commit that referenced this pull request Sep 25, 2015
PR-URL: #3016 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
This was referenced Sep 30, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pmq20@targos@silverwind@brendanashworth