Skip to content

Conversation

@dev-script
Copy link
Contributor

@dev-scriptdev-script commented Oct 30, 2019

Line added in the description of http2 aborted event
that it's listener does not expect any arguments.

Fixes: nodejs/help#877

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Oct 30, 2019
@dev-scriptdev-script changed the title docs: improve doc Http2Stream:Aborteddoc: improve doc Http2Stream:AbortedOct 30, 2019
Line added in the description of http2 aborted event that it's listener does not expect any arguments. Fixes: nodejs/help#877
@gireeshpunathil
Copy link
Member

@dev-313 - if you are planning to attack all of those pending http2 event arguments mentioned in the referenced issue, it may be a good idea to combine the rest into one single PR - easy to review, easy to manage.

@dev-script
Copy link
ContributorAuthor

Okay @gireeshpunathil . Thanks

@trivikr
Copy link
Member

@trivikrtrivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 31, 2019
@nodejs-github-bot
Copy link
Collaborator

@gireeshpunathil
Copy link
Member

@nodejs/build - can you please review https://ci.nodejs.org/job/node-linter/3957/console and advise what is going on? does not look like a normal build failure to me.

@richardlau
Copy link
Member

richardlau commented Oct 31, 2019

@nodejs/build - can you please review https://ci.nodejs.org/job/node-linter/3957/console and advise what is going on? does not look like a normal build failure to me.

@rvagg I think this is related to nodejs/build#2012 (comment).

The Pre-flight stage of https://ci.nodejs.org/job/node-linter/ calls https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-pre.sh

sh "curl -L -s https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-pre.sh -s | bash -xe"

which calls https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-diagnostics.sh
which tries to write to DIAGFILE=${HOME}/jenkins_diagnostics.txt and fails:

01:40:36 + curl https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-diagnostics.sh01:40:36 + bash -ex -s before01:40:36 % Total % Received % Xferd Average Speed Time Time Time Current01:40:36 Dload Upload Total Spent Left Speed01:40:37  0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0100 985 100 985 0 0 3315 0 --:--:-- --:--:-- --:--:-- 332701:40:37 + set +x01:40:37 bash: line 9: /jenkins_diagnostics.txt: Permission denied

suggesting ${HOME} is empty?

@rvagg
Copy link
Member

Yes, and I can't work out why $HOME is missing now that we've switched from FreeBSD to Linux for this. There's no special environment variables on the host machine.

@rvagg
Copy link
Member

I've restored the old FreeBSD servers while we figure this one out. These pipeline builds are the worst for debugging, I've got no idea where HOME has gone to, it's not showing up on an env from the script but there's nothing particularly special about the FreeBSD env compared to the Ubuntu one for that.

@rvagg
Copy link
Member

Got this sorted out, it was a configuration weirdness specific to the machine that has the most likelihood of being chosen for this task nodejs/build#2021, it's now back off FreeBSD.

gireeshpunathil pushed a commit that referenced this pull request Nov 3, 2019
Line added in the description of http2 aborted event that it's listener does not expect any arguments. Refs: nodejs/help#877 PR-URL: #30179 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@gireeshpunathil
Copy link
Member

landed as 8b53d0b

targos pushed a commit that referenced this pull request Nov 5, 2019
Line added in the description of http2 aborted event that it's listener does not expect any arguments. Refs: nodejs/help#877 PR-URL: #30179 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@targostargos mentioned this pull request Nov 5, 2019
targos pushed a commit that referenced this pull request Nov 8, 2019
Line added in the description of http2 aborted event that it's listener does not expect any arguments. Refs: nodejs/help#877 PR-URL: #30179 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
Line added in the description of http2 aborted event that it's listener does not expect any arguments. Refs: nodejs/help#877 PR-URL: #30179 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Nov 10, 2019
Line added in the description of http2 aborted event that it's listener does not expect any arguments. Refs: nodejs/help#877 PR-URL: #30179 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@targostargos mentioned this pull request Nov 10, 2019
targos pushed a commit that referenced this pull request Nov 11, 2019
Line added in the description of http2 aborted event that it's listener does not expect any arguments. Refs: nodejs/help#877 PR-URL: #30179 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document event arguments (http2, maybe more)

6 participants

@dev-script@gireeshpunathil@trivikr@nodejs-github-bot@richardlau@rvagg