tools: make doctool work if no internet available#30214
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
richardlauforce-pushed the nointernetdoctests branch from a3d45c1 to 3cb0fedCompare
Collaborator
nodejs-github-bot commented Nov 2, 2019
Uh oh!
There was an error while loading. Please reload this page.
Trott approved these changes Nov 3, 2019
Collaborator
nodejs-github-bot commented Nov 3, 2019
Collaborator
nodejs-github-bot commented Nov 3, 2019
richardlauforce-pushed the nointernetdoctests branch 3 times, most recently from 7d2a1b6 to 3ce1da5Compare
devsnek approved these changes Nov 3, 2019
MemberAuthor
richardlau commented Nov 3, 2019
ARM builds currently have issues unrelated to this PR (nodejs/build#2028) so holding off rerunning CI until they're resolved. |
legendecas approved these changes Nov 4, 2019
BridgeAR approved these changes Nov 5, 2019
Collaborator
nodejs-github-bot commented Nov 6, 2019
richardlau added author ready Collaborator
nodejs-github-bot commented Nov 6, 2019
gengjiawen approved these changes Nov 6, 2019
Allow doctool to fallback to use local files if not building a release build. PR-URL: nodejs#30214Fixes: nodejs#29918 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
richardlauforce-pushed the nointernetdoctests branch from 3ce1da5 to 3b124e0CompareMemberAuthor
richardlau commented Nov 6, 2019
Landed in 3b124e0. |
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
Allow doctool to fallback to use local files if not building a release build. PR-URL: #30214Fixes: #29918 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
Allow doctool to fallback to use local files if not building a release build. PR-URL: #30214Fixes: #29918 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
Allow doctool to fallback to use local files if not building a release build. PR-URL: #30214Fixes: #29918 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Merged
3 tasks
richardlau added a commit to richardlau/node-1 that referenced this pull request Apr 6, 2020
Allow doctool to fallback to use local files if not building a release build. Backport-PR-URL: nodejs#32642 PR-URL: nodejs#30214Fixes: nodejs#29918 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 6, 2020
Allow doctool to fallback to use local files if not building a release build. Backport-PR-URL: #32642 PR-URL: #30214Fixes: #29918 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow doctool to fallback to use local files if not building a release
build.
Fixes: #29918
cc @joyeecheung
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes