esm: exit the process with an error if loader has an issue#30219
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Previously, this would trigger an unhandled rejection that the user cannot handle. Fixes: nodejs#30205
targos added the esm 
guybedford approved these changes Nov 2, 2019
Contributor
guybedford left a comment
guybedford left a comment There was a problem hiding this comment.
Thanks for looking into this.
cjihrig approved these changes Nov 3, 2019
guybedford added the author ready 
addaleax approved these changes Nov 5, 2019
Collaborator
nodejs-github-bot commented Nov 5, 2019
Collaborator
nodejs-github-bot commented Nov 6, 2019
Collaborator
nodejs-github-bot commented Nov 6, 2019
Collaborator
nodejs-github-bot commented Nov 8, 2019
Collaborator
nodejs-github-bot commented Nov 8, 2019
ZYSzys approved these changes Nov 9, 2019
Collaborator
nodejs-github-bot commented Nov 9, 2019
MemberAuthor
targos commented Nov 9, 2019
Landed in 8bb83f4 |
targos added a commit that referenced this pull request Nov 9, 2019
Previously, this would trigger an unhandled rejection that the user cannot handle. Fixes: #30205 PR-URL: #30219 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
Previously, this would trigger an unhandled rejection that the user cannot handle. Fixes: #30205 PR-URL: #30219 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jan 12, 2020
Previously, this would trigger an unhandled rejection that the user cannot handle. Fixes: #30205 PR-URL: #30219 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
Previously, this would trigger an unhandled rejection that the user cannot handle. Fixes: #30205 PR-URL: #30219 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Merged
codebytere added a commit to electron/electron that referenced this pull request Feb 21, 2020
codebytere added a commit to electron/electron that referenced this pull request Feb 21, 2020
codebytere added a commit to electron/electron that referenced this pull request Feb 21, 2020
codebytere added a commit to electron/electron that referenced this pull request Feb 24, 2020
codebytere added a commit to electron/electron that referenced this pull request Feb 24, 2020
* chore: bump node in DEPS to v12.16.0 * Fixup asar support setup patch nodejs/node#30862 * Fixup InternalCallbackScope patch nodejs/node#30236 * Fixup GN buildfiles patch nodejs/node#30755 * Fixup low-level hooks patch nodejs/node#30466 * Fixup globals require patch nodejs/node#31643 * Fixup process stream patch nodejs/node#30862 * Fixup js2c modification patch nodejs/node#30755 * Fixup internal fs override patch nodejs/node#30610 * Fixup context-aware warn patch nodejs/node#30336 * Fixup Node.js with ltcg config nodejs/node#29388 * Fixup oaepLabel patch nodejs/node#30917 * Remove redundant ESM test patch nodejs/node#30997 * Remove redundant cli flag patch nodejs/node#30466 * Update filenames.json * Remove macro generation in GN build files nodejs/node#30755 * Fix some compilation errors upstream * Add uvwasi to deps nodejs/node#30258 * Fix BoringSSL incompatibilities * Fixup linked module patch nodejs/node#30274 * Add missing sources to GN uv build libuv/libuv#2347 * Patch some uvwasi incompatibilities * chore: bump Node.js to v12.6.1 * Remove mark_arraybuffer_as_untransferable.patch nodejs/node#30549 * Fix uvwasi build failure on win * Fixup --perf-prof cli option error * Fixup early cjs module loading * fix: initialize diagnostics properly nodejs/node#30025 * Disable new esm syntax specs nodejs/node#30219 * Fixup v8 weakref hook spec nodejs/node#29874 * Fix async context timer issue * Disable monkey-patch-main spec It relies on nodejs/node#29777, and we don't override prepareStackTrace. * Disable new tls specs nodejs/node#23188 We don't support much of TLS owing to schisms between BoringSSL and OpenSSL. Co-authored-by: Shelley Vohr <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this would trigger an unhandled rejection that the user
cannot handle.
Fixes: #30205
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes