v8: mark serdes API as stable#30234
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This has been around for a long time, and the underlying V8 API has become stable as well a while ago.
gireeshpunathil approved these changes Nov 3, 2019
targos approved these changes Nov 3, 2019
Member
targos commented Nov 3, 2019
Notable change? |
lpinca approved these changes Nov 3, 2019
cjihrig approved these changes Nov 3, 2019
cjihrig added the notable-change 
devsnek approved these changes Nov 3, 2019
trivikr approved these changes Nov 3, 2019
gengjiawen approved these changes Nov 4, 2019
BridgeAR approved these changes Nov 5, 2019
jasnell approved these changes Nov 5, 2019
addaleax added the author ready 
Collaborator
nodejs-github-bot commented Nov 5, 2019
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/26363/ Edit: Jobs that are relevant for docs PRs/that are run by the lite CI are good |
MemberAuthor
addaleax commented Nov 5, 2019
Landed in f734ba9 🎉 |
addaleax added a commit that referenced this pull request Nov 5, 2019
This has been around for a long time, and the underlying V8 API has become stable as well a while ago. PR-URL: #30234 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
This has been around for a long time, and the underlying V8 API has become stable as well a while ago. PR-URL: #30234 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins added a commit to BridgeAR/node that referenced this pull request Nov 21, 2019
Notable changes: * addons: * Deprecate one- and two-argument `AtExit()`. Use the three-argument variant of `AtExit()` or `AddEnvironmentCleanupHook()` instead (Anna Henningsen) nodejs#30227 * child_process,cluster: * The `serialization` option is added that allows child process IPC to use the V8 serialization API (to e.g., pass through data types like sets or maps) (Anna Henningsen) nodejs#30162 * deps: * Update V8 to 7.9 * Update `npm` to 6.13.0 (Ruy Adorno) nodejs#30271 * embedder: * Exposes the ability to pass cli flags / options through an API as embedder (Shelley Vohr) nodejs#30466 * Allow adding linked bindings to Environment (Anna Henningsen) nodejs#30274 * esm: * Unflag --experimental-modules (Guy Bedford) nodejs#29866 * stream: * Add `writable.writableCorked` property (Robert Nagy) nodejs#29012 * worker: * Allow specifying resource limits (Anna Henningsen) nodejs#26628 * v8: * The Serialization API is now stable (Anna Henningsen) nodejs#30234 PR-URL: nodejs#30547
MylesBorins added a commit that referenced this pull request Nov 21, 2019
Notable changes: * addons: * Deprecate one- and two-argument `AtExit()`. Use the three-argument variant of `AtExit()` or `AddEnvironmentCleanupHook()` instead (Anna Henningsen) #30227 * child_process,cluster: * The `serialization` option is added that allows child process IPC to use the V8 serialization API (to e.g., pass through data types like sets or maps) (Anna Henningsen) #30162 * deps: * Update V8 to 7.9 * Update `npm` to 6.13.0 (Ruy Adorno) #30271 * embedder: * Exposes the ability to pass cli flags / options through an API as embedder (Shelley Vohr) #30466 * Allow adding linked bindings to Environment (Anna Henningsen) #30274 * esm: * Unflag --experimental-modules (Guy Bedford) #29866 * stream: * Add `writable.writableCorked` property (Robert Nagy) #29012 * worker: * Allow specifying resource limits (Anna Henningsen) #26628 * v8: * The Serialization API is now stable (Anna Henningsen) #30234 PR-URL: #30547
bruce-one added a commit to bruce-one/node that referenced this pull request Nov 24, 2019
As nodejs#30234 marked this as stable I think this line should be removed as well?
addaleax pushed a commit that referenced this pull request Nov 27, 2019
As #30234 marked this as stable I think this line should be removed as well? Refs: #30234 PR-URL: #30631 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
addaleax pushed a commit that referenced this pull request Nov 30, 2019
As #30234 marked this as stable I think this line should be removed as well? Refs: #30234 PR-URL: #30631 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
targos pushed a commit that referenced this pull request Dec 1, 2019
This has been around for a long time, and the underlying V8 API has become stable as well a while ago. PR-URL: #30234 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Dec 1, 2019
As #30234 marked this as stable I think this line should be removed as well? Refs: #30234 PR-URL: #30631 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Closed
BethGriggs added a commit that referenced this pull request Dec 9, 2019
Notable changes: - crypto: fix key requirements in asymmetric cipher (Tobias Nießen) #30249 - deps: - update llhttp to 2.0.1 (Fedor Indutny) #30553 - upgrade npm to 6.13.1 (claudiahdz) #30533 - update nghttp2 to 1.40.0 (gengjiawen) #30493 - v8: mark serdes API as stable (Anna Henningsen) #30234 PR-URL: #30865
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
This has been around for a long time, and the underlying V8 API has become stable as well a while ago. PR-URL: #30234 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
As #30234 marked this as stable I think this line should be removed as well? Refs: #30234 PR-URL: #30631 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been around for a long time, and the underlying V8 API has
become stable as well a while ago.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes