http2: fix session memory tracking and small clean up#30351
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
lundibundi changed the title 
addaleax approved these changes Nov 10, 2019
Member
addaleax left a comment
addaleax left a comment There was a problem hiding this comment.
I guess if you want to write a test for this, you could build something based on test-http2-generic-streams.js that triggers this condition and takes a heap dump?
devnexen approved these changes Nov 10, 2019
jasnell approved these changes Nov 12, 2019
Collaborator
nodejs-github-bot commented Nov 16, 2019
Collaborator
lundibundi added the author ready 3 tasks
lundibundi added blocked 
MemberAuthor
lundibundi commented Nov 29, 2019
Waiting for this #30684 to land. I'll then rebase and update this. |
* avoid consecutive decrement/increment session memory calls. * only Resize the buffer when it is needed. * flip `stream_buf_offset_` condition to the LIKELY case.
lundibundiforce-pushed the fix-http2-read-memory-track branch from d004aaf to 542924eCompareCollaborator
nodejs-github-bot commented Dec 1, 2019
MemberAuthor
lundibundi commented Dec 1, 2019
Collaborator
nodejs-github-bot commented Dec 2, 2019
MemberAuthor
lundibundi commented Dec 5, 2019
addaleax approved these changes Dec 5, 2019
addaleax added the author ready jasnell approved these changes Dec 5, 2019
addaleax pushed a commit that referenced this pull request Dec 6, 2019
PR-URL: #30351 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Dec 6, 2019
* avoid consecutive decrement/increment session memory calls. * only Resize the buffer when it is needed. * flip `stream_buf_offset_` condition to the LIKELY case. PR-URL: #30351 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
addaleax commented Dec 6, 2019
Landed in bfd9de6...51ccf1b |
targos pushed a commit that referenced this pull request Dec 9, 2019
PR-URL: #30351 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Dec 9, 2019
* avoid consecutive decrement/increment session memory calls. * only Resize the buffer when it is needed. * flip `stream_buf_offset_` condition to the LIKELY case. PR-URL: #30351 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
targos pushed a commit that referenced this pull request Jan 13, 2020
PR-URL: #30351 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jan 13, 2020
* avoid consecutive decrement/increment session memory calls. * only Resize the buffer when it is needed. * flip `stream_buf_offset_` condition to the LIKELY case. PR-URL: #30351 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #30351 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
* avoid consecutive decrement/increment session memory calls. * only Resize the buffer when it is needed. * flip `stream_buf_offset_` condition to the LIKELY case. PR-URL: #30351 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
lundibundi added a commit to lundibundi/node that referenced this pull request Jul 22, 2020
4 tasks
mcollina pushed a commit that referenced this pull request Jul 27, 2020
Refs: #34315 Refs: #30351 PR-URL: #34480 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
Refs: #34315 Refs: #30351 PR-URL: #34480 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]>
codebytere pushed a commit that referenced this pull request Nov 3, 2020
Refs: #34315 Refs: #30351 PR-URL: #34480 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
Refs: #34315 Refs: #30351 PR-URL: #34480 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passeshttp2: fix session memory tracking with pending input data
Previously
DecrementCurrentSessionMemorycall was made after the relevant variable was reset to0.http2: small clean up in OnStreamRead
Extract pending input memory size in a variable and change code appropriately.
Not sure how to reliably hit the changed case, could someone help so I can write a test for
DecrementCurrentSessionMemory?