Skip to content

lib: replace var with let/const#30394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kresimirfranin wants to merge 1 commit into from
Closed

lib: replace var with let/const #30394

kresimirfranin wants to merge 1 commit into from

Conversation

@kresimirfranin
Copy link
Contributor

@kresimirfraninkresimirfranin commented Nov 12, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the zlib Issues and PRs related to the zlib subsystem. label Nov 12, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 12, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26521/

@jasnelljasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 12, 2019
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Nov 13, 2019

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4052/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 16, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26611/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 25, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26956/

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 25, 2019

@kresimirfranin - this needs a rebase (the upstream is changed since the time you took a snapshot).

@addaleaxaddaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 29, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Dec 25, 2019

Ping @kresimirfranin

@kresimirfraninkresimirfraninforce-pushed the node_conf_var_to_let_zlib branch from 65e26c6 to 808169bCompareDecember 28, 2019 12:04
@kresimirfranin
Copy link
ContributorAuthor

kresimirfranin commented Dec 28, 2019

@gireeshpunathil@BridgeAR sry, done

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 28, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27991/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 28, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27992/

@gireeshpunathilgireeshpunathil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 28, 2019
@gireeshpunathil
Copy link
Member

gireeshpunathil commented Dec 28, 2019

the only failure in AIX sequential/test-http2-settings-flood is known as in #31107

gireeshpunathil pushed a commit that referenced this pull request Dec 28, 2019
@kresimirfranin@gireeshpunathil
lib: replace var with let/const
a412a97
PR-URL: #30394 Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@gireeshpunathil
Copy link
Member

gireeshpunathil commented Dec 28, 2019

landed in a412a97 , thanks for the contribution!

@Trott
Copy link
Member

Trott commented Dec 29, 2019

For code-and-learn commits like this one, it would be good for us to make a habit of updating the commit message when landing. This one says lib and makes no mention of zlib so it appears more significant than it is until you look at the actual change.

I'll try to be better about flagging these things myself, although I didn't review this one at all.

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Dec 29, 2019

@Trott - acknowledged!

BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@kresimirfranin@BridgeAR
lib: replace var with let/const
97ce0a3
PR-URL: #30394 Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeARBridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@kresimirfranin@targos
lib: replace var with let/const
afd8caf
PR-URL: #30394 Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Jan 14, 2020
@kresimirfranin@targos
lib: replace var with let/const
4a7e860
PR-URL: #30394 Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@kresimirfranin@BethGriggs
lib: replace var with let/const
59101b5
PR-URL: #30394 Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

@BridgeARBridgeARBridgeAR approved these changes

@trivikrtrivikrtrivikr approved these changes

+1 more reviewer

@devnexendevnexendevnexen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.zlibIssues and PRs related to the zlib subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@kresimirfranin@nodejs-github-bot@BridgeAR@gireeshpunathil@Trott@jasnell@devnexen@trivikr@addaleax