Skip to content

test: use spread object#30423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
franher wants to merge 1 commit into from
Closed

test: use spread object #30423

franher wants to merge 1 commit into from

Conversation

@franher
Copy link
Contributor

@franherfranher commented Nov 12, 2019

Object.assign() can be replaced by spread objects {... }

Refs: https://eslint.org/docs/rules/prefer-object-spread

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 12, 2019
@jasnelljasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 12, 2019
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
jasnell
jasnell reviewed Nov 12, 2019
View reviewed changes
@franher
Copy link
ContributorAuthor

franher commented Nov 12, 2019

@jasnell I will fix the linting errors and commit the changes. I have run make lint-js-fix but no errors were shown initially.

Thank you for your review

@franher
Copy link
ContributorAuthor

franher commented Nov 12, 2019

Committed the fix on 16280f99f2a9e7ccdee12cc3932a222200a9bb18

@franherfranher requested a review from jasnellNovember 13, 2019 11:58
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26556/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26743/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 25, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26941/

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 25, 2019

@franher - this needs a rebase, thanks

@addaleaxaddaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 29, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Dec 25, 2019

Ping @franher

@franher@BridgeAR
test: use spread object
f69937d
Object.assign() can be replaced by spread objects Refs: https://eslint.org/docs/rules/prefer-object-spread
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 2, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 2, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28105/

BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@franher@BridgeAR
test: use spread object
c52ebc0
Object.assign() can be replaced by spread objects PR-URL: #30423 Refs: https://eslint.org/docs/rules/prefer-object-spread Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@BridgeAR
Copy link
Member

BridgeAR commented Jan 3, 2020

Landed in c52ebc0 🎉

@BridgeARBridgeAR closed this Jan 3, 2020
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@franher@BridgeAR
test: use spread object
bd6a29c
Object.assign() can be replaced by spread objects PR-URL: #30423 Refs: https://eslint.org/docs/rules/prefer-object-spread Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@BridgeARBridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@franher@targos
test: use spread object
4022617
Object.assign() can be replaced by spread objects PR-URL: #30423 Refs: https://eslint.org/docs/rules/prefer-object-spread Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@franher@BethGriggs
test: use spread object
05ef4bd
Object.assign() can be replaced by spread objects PR-URL: #30423 Refs: https://eslint.org/docs/rules/prefer-object-spread Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@TrottTrottTrott approved these changes

@cjihrigcjihrigcjihrig approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

@BridgeARBridgeARBridgeAR approved these changes

@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@franher@nodejs-github-bot@gireeshpunathil@BridgeAR@jasnell@Trott@cjihrig@trivikr@addaleax