lib: use let instead of var for lib/internal/policy/manifest.js#30424
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cjihrig approved these changes Nov 12, 2019
addaleax approved these changes Nov 12, 2019
addaleax added the code-and-learn addaleax approved these changes Nov 12, 2019
jasnell approved these changes Nov 12, 2019
trivikr approved these changes Nov 13, 2019
BridgeAR approved these changes Nov 13, 2019
BridgeAR added the author ready 
Collaborator
nodejs-github-bot commented Nov 13, 2019
jasnell approved these changes Nov 14, 2019
gireeshpunathil approved these changes Nov 17, 2019
Collaborator
nodejs-github-bot commented Nov 19, 2019
Collaborator
nodejs-github-bot commented Nov 25, 2019
Member
gireeshpunathil commented Nov 25, 2019
Member
gireeshpunathil commented Nov 25, 2019
the linnux-containerized failure |
gireeshpunathil pushed a commit that referenced this pull request Nov 25, 2019
use let instead of var for lib/internal/policy/manifest.js PR-URL: #30424 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Member
gireeshpunathil commented Nov 25, 2019
landed in dfbdfb4. |
ContributorAuthor
edspace commented Nov 25, 2019
|
addaleax pushed a commit that referenced this pull request Nov 30, 2019
use let instead of var for lib/internal/policy/manifest.js PR-URL: #30424 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Dec 1, 2019
use let instead of var for lib/internal/policy/manifest.js PR-URL: #30424 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
use let instead of var for lib/internal/policy/manifest.js PR-URL: #30424 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes