doc: adds assert doc for strict mode with pointer to strict equality#30486
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added assert Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
BridgeAR approved these changes Nov 15, 2019
ContributorAuthor
shobhitchittora commented Nov 15, 2019
@BridgeAR My bad! Just clicked on re-review. 😛 |
lpinca approved these changes Nov 15, 2019
trivikr approved these changes Nov 15, 2019
gireeshpunathil approved these changes Nov 16, 2019
Collaborator
nodejs-github-bot commented Nov 16, 2019
Collaborator
nodejs-github-bot commented Nov 22, 2019
addaleax added the author ready Collaborator
nodejs-github-bot commented Nov 27, 2019
Collaborator
nodejs-github-bot commented Nov 29, 2019
Contributor
cjihrig commented Nov 29, 2019
I killed the CI run since it had been running for over 6 hours. Since this is a doc only PR, it doesn't need a full CI run anyway. cc: @nodejs/build |
addaleax pushed a commit that referenced this pull request Dec 3, 2019
Refs: #30485 PR-URL: #30486 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Member
addaleax commented Dec 3, 2019
Landed in dbdad4d |
targos pushed a commit that referenced this pull request Dec 9, 2019
Refs: #30485 PR-URL: #30486 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
targos pushed a commit that referenced this pull request Jan 13, 2020
Refs: #30485 PR-URL: #30486 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
Refs: #30485 PR-URL: #30486 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a note to not confuse strict mode in
assertmodule with JS"use strict"directive.Refs: #30485
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes