events: improve performance caused by primordials#30577
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the events 
cjihrig approved these changes Nov 21, 2019
lib/events.js Outdated
Contributor
There was a problem hiding this comment.
The variables ReflectApply and apply are the same thing. I think one of them can be removed.
ContributorAuthor
There was a problem hiding this comment.
That's right. I have changed it. Thanks!
antimonyGuforce-pushed the events-primordials branch from 916086e to 175a3a5Compare
targos approved these changes Nov 21, 2019
ZYSzys approved these changes Nov 22, 2019
Collaborator
nodejs-github-bot commented Nov 22, 2019
ContributorAuthor
antimonyGu commented Nov 22, 2019
Dear all reviewers, I see several builds fails on Jenkins, and most of them seem like a same problem. But I don't know how to fix them and the exact reason of the failure reason. Can anybody help me? Thanks very much! |
gireeshpunathil approved these changes Nov 22, 2019
Collaborator
nodejs-github-bot commented Nov 22, 2019
Member
gireeshpunathil commented Nov 22, 2019
@antimonyGu - there were unrelated issues that caused this failures, not a cause of worry for you! those are being addressed, so I have re-triggered the CI. Let us see! |
ContributorAuthor
antimonyGu commented Nov 22, 2019
@gireeshpunathil Thanks very much! |
Member
targos commented Nov 22, 2019
Please 👍 to fast-track. |
Trott pushed a commit that referenced this pull request Nov 23, 2019
PR-URL: #30577 Refs: nodejs/code-and-learn#97 Refs: #29766 Refs: #29633 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Member
Trott commented Nov 23, 2019
Landed in e5cbbe0. Thanks for the contribution! 🎉 |
addaleax pushed a commit that referenced this pull request Nov 30, 2019
PR-URL: #30577 Refs: nodejs/code-and-learn#97 Refs: #29766 Refs: #29633 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
targos pushed a commit that referenced this pull request Dec 1, 2019
PR-URL: #30577 Refs: nodejs/code-and-learn#97 Refs: #29766 Refs: #29633 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
PR-URL: #30577 Refs: nodejs/code-and-learn#97 Refs: #29766 Refs: #29633 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Refs: nodejs/code-and-learn#97
Refs: #29766
Refs: #29633
make -j4 test(UNIX), orvcbuild test(Windows) passes