Fixed a typo in a date for version 13.2.0#30587
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
targos reviewed Nov 22, 2019
doc/changelogs/CHANGELOG_V13.md Outdated
| <aid="13.2.0"></a> | ||
| ## 2019-21-19, Version 13.2.0 (Current), @MylesBorins | ||
| ## 2019-11-21git log --oneline files/you/changed, Version 13.2.0 (Current), @MylesBorins |
Member
There was a problem hiding this comment.
Suggested change
| ## 2019-11-21git log --oneline files/you/changed, Version 13.2.0 (Current), @MylesBorins | |
| ## 2019-11-21, Version 13.2.0 (Current), @MylesBorins |
😉
Author
There was a problem hiding this comment.
Sorry, will fix, Bad with texts too 🙂
Member
targos commented Nov 22, 2019
collaborators: 👍 to fast-track |
gireeshpunathil approved these changes Nov 22, 2019
Author
kirlat commented Nov 22, 2019
I see that a check fails because it does not see subsystem in the commit message. I've checked other commit messages for this file and they do not have subsystem too. Don't know if I need to do anything about it or not (never committed to node.js before 🙂) |
Member
targos commented Nov 22, 2019
|
BethGriggs approved these changes Nov 22, 2019
addaleax approved these changes Nov 22, 2019
Member
addaleax commented Nov 22, 2019
Landed in f6de66e, thanks for the PR! |
addaleax pushed a commit that referenced this pull request Nov 22, 2019
PR-URL: #30587 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Nov 30, 2019
PR-URL: #30587 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Fixed a typo in a date for version 13.2.0. See #30585