tools: update ESLint to 6.7.1#30598
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lpinca approved these changes Nov 22, 2019
targos approved these changes Nov 22, 2019
trivikr approved these changes Nov 22, 2019
cjihrig added the author ready 
Collaborator
nodejs-github-bot commented Nov 25, 2019
Collaborator
nodejs-github-bot commented Nov 25, 2019
Collaborator
nodejs-github-bot commented Nov 25, 2019
Collaborator
nodejs-github-bot commented Nov 25, 2019
Collaborator
nodejs-github-bot commented Nov 25, 2019
ContributorAuthor
cjihrig commented Nov 25, 2019
There is one remaining failure on ubuntu1804_sharedlibs_shared_x64: That test has failed on a few runs now, including in other PRs (https://ci.nodejs.org/job/node-test-commit-linux-containered/16163/). Since an ESLint update is unlikely to cause this failure, and because it's showing up elsewhere, I'm going to move forward with landing this. |
Update ESLint to 6.7.1 PR-URL: nodejs#30598 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
This commit enables these new in ESLint 6.7.0 rules: - no-constructor-return - no-dupe-else-if - no-setter-return PR-URL: nodejs#30598 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
ContributorAuthor
cjihrig commented Nov 25, 2019
Landed in 02d4c74...a50cc2e. |
addaleax pushed a commit that referenced this pull request Nov 30, 2019
Update ESLint to 6.7.1 PR-URL: #30598 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
addaleax pushed a commit that referenced this pull request Nov 30, 2019
This commit enables these new in ESLint 6.7.0 rules: - no-constructor-return - no-dupe-else-if - no-setter-return PR-URL: #30598 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Dec 1, 2019
Update ESLint to 6.7.1 PR-URL: #30598 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Dec 1, 2019
This commit enables these new in ESLint 6.7.0 rules: - no-constructor-return - no-dupe-else-if - no-setter-return PR-URL: #30598 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
Update ESLint to 6.7.1 PR-URL: #30598 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
This commit enables these new in ESLint 6.7.0 rules: - no-constructor-return - no-dupe-else-if - no-setter-return PR-URL: #30598 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also enables a handful of new ESLint rules that were added in 6.7.0.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes