test: use useful message argument in test function#30618
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Nov 24, 2019
trivikr approved these changes Nov 24, 2019
lpinca approved these changes Nov 24, 2019
cjihrig approved these changes Nov 24, 2019
Collaborator
ZYSzys approved these changes Nov 24, 2019
Trott added the author ready 
tniessen approved these changes Nov 25, 2019
The message argument of two test functions in test-inspector-async-call-stack is useful but unused. Use it! PR-URL: nodejs#30618 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MemberAuthor
Trott commented Nov 26, 2019
Landed in a6fd282 |
addaleax pushed a commit that referenced this pull request Nov 30, 2019
The message argument of two test functions in test-inspector-async-call-stack is useful but unused. Use it! PR-URL: #30618 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Dec 1, 2019
The message argument of two test functions in test-inspector-async-call-stack is useful but unused. Use it! PR-URL: #30618 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
The message argument of two test functions in test-inspector-async-call-stack is useful but unused. Use it! PR-URL: #30618 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The message argument of two test functions in
test-inspector-async-call-stack is useful but unused. Use it!
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes