module: fix dynamic import from eval#30624
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the process 
devsnek approved these changes Nov 25, 2019
yorkie reviewed Nov 25, 2019
Uh oh!
There was an error while loading. Please reload this page.
coreyfarrellforce-pushed the eval-dynamic-import branch from 9651517 to e96ebc2Compare
MylesBorins added the esm 
Collaborator
nodejs-github-bot commented Nov 27, 2019
MemberAuthor
coreyfarrell commented Nov 27, 2019
I'm not sure what to do here, it doesn't look like the crash is caused by my change? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
coreyfarrellforce-pushed the eval-dynamic-import branch from e96ebc2 to 2d0c869Compare
bcoe reviewed Nov 30, 2019
Uh oh!
There was an error while loading. Please reload this page.
bcoe suggested changes Nov 30, 2019
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bcoe approved these changes Dec 5, 2019
Contributor
bcoe commented Dec 5, 2019
@coreyfarrell@guybedford this looks quite reasonable to me; @coreyfarrell when you have a moment, want to work on debugging the Travis tests? at which point I can kick off ci/cd? |
coreyfarrellforce-pushed the eval-dynamic-import branch from 231b8c3 to 523c187CompareMemberAuthor
coreyfarrell commented Dec 5, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This allows dynamic import to work from CLI `--eval` with or without `--input-type=module`. Fixes: nodejs#30591
coreyfarrellforce-pushed the eval-dynamic-import branch from 523c187 to bcc0331Compare This comment has been minimized.
This comment has been minimized.
bcoe approved these changes Dec 6, 2019
Collaborator
nodejs-github-bot commented Dec 6, 2019
bcoe approved these changes Dec 7, 2019
Contributor
bcoe left a comment
bcoe left a comment There was a problem hiding this comment.
It looks like the most recent test run was successful, I am going to go ahead and land this.
bcoe pushed a commit that referenced this pull request Dec 7, 2019
This allows dynamic import to work from CLI `--eval` with or without `--input-type=module`. Fixes: #30591 PR-URL: #30624 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Yorkie Liu <[email protected]> Reviewed-By: Ben Coe <[email protected]>
Contributor
bcoe commented Dec 7, 2019
Landed in 4ec02d5 |
targos pushed a commit that referenced this pull request Dec 9, 2019
This allows dynamic import to work from CLI `--eval` with or without `--input-type=module`. Fixes: #30591 PR-URL: #30624 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Yorkie Liu <[email protected]> Reviewed-By: Ben Coe <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jan 12, 2020
This allows dynamic import to work from CLI `--eval` with or without `--input-type=module`. Fixes: #30591 PR-URL: #30624 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Yorkie Liu <[email protected]> Reviewed-By: Ben Coe <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
This allows dynamic import to work from CLI `--eval` with or without `--input-type=module`. Fixes: #30591 PR-URL: #30624 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Yorkie Liu <[email protected]> Reviewed-By: Ben Coe <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows dynamic import to work from CLI
--evalwith or without--input-type=module.Fixes: #30591
Checklist
make -j4 test(UNIX)