Skip to content

Conversation

@BethGriggs
Copy link
Member

@BethGriggsBethGriggs commented Nov 25, 2019

Added note about coordinating major releases with npm

//cc @nodejs/release

Checklist

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 25, 2019
Copy link
Contributor

@MylesBorinsMylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BethGriggs
Copy link
MemberAuthor

@BethGriggsBethGriggs added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 26, 2019
BethGriggs added a commit that referenced this pull request Nov 27, 2019
PR-URL: #30636 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Yorkie Liu <[email protected]>
@BethGriggs
Copy link
MemberAuthor

Landed in 5904dfc

@BethGriggsBethGriggs deleted the release-updates branch November 27, 2019 17:43
addaleax pushed a commit that referenced this pull request Nov 30, 2019
PR-URL: #30636 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Yorkie Liu <[email protected]>
targos pushed a commit that referenced this pull request Dec 1, 2019
PR-URL: #30636 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Yorkie Liu <[email protected]>
@BridgeARBridgeAR mentioned this pull request Dec 3, 2019
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
PR-URL: #30636 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Yorkie Liu <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@BethGriggs@MylesBorins@antsmartian@lpinca@yorkie@targos@richardlau@nodejs-github-bot