Skip to content

doc: update socket.bufferSize text#30723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Trott merged 0 commits into from
Dec 2, 2019
Merged

doc: update socket.bufferSize text #30723

Trott merged 0 commits into from
Dec 2, 2019

Conversation

@Trott
Copy link
Member

@TrottTrott commented Nov 30, 2019

Edit text for clarity and readability.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Nov 30, 2019
addaleax
addaleax approved these changes Nov 30, 2019
View reviewed changes
@TrottTrott requested a review from addaleaxNovember 30, 2019 01:22
@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 30, 2019
@Trott
Copy link
MemberAuthor

Trott commented Dec 2, 2019

Landed in 7f7d858

@TrottTrott closed this Dec 2, 2019
@TrottTrott deleted the currently branch December 2, 2019 04:52
@TrottTrott merged commit 7f7d858 into nodejs:masterDec 2, 2019
targos pushed a commit that referenced this pull request Dec 2, 2019
@Trott@targos
doc: update socket.bufferSize text
f46df0b
Edit text for clarity and readability. PR-URL: #30723 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
@BridgeARBridgeAR mentioned this pull request Dec 3, 2019
Merged
targos pushed a commit that referenced this pull request Dec 5, 2019
@Trott@targos
doc: update socket.bufferSize text
898f236
Edit text for clarity and readability. PR-URL: #30723 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@Trott@MylesBorins
doc: update socket.bufferSize text
4e93f23
Edit text for clarity and readability. PR-URL: #30723 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Dec 31, 2019
@Trott@BethGriggs
doc: update socket.bufferSize text
2afe757
Edit text for clarity and readability. PR-URL: #30723 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.netIssues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@jasnell@addaleax@gireeshpunathil@nodejs-github-bot