doc: revise REPL uncaught exception text#30729
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
gireeshpunathil approved these changes Nov 30, 2019
antsmartian approved these changes Nov 30, 2019
Trott added the author ready 
targos approved these changes Nov 30, 2019
BethGriggs approved these changes Nov 30, 2019
trivikr approved these changes Nov 30, 2019
Simplify the text about uncaught exceptions in the REPL. PR-URL: nodejs#30729 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MemberAuthor
Trott commented Dec 2, 2019
Landed in b419d28 |
targos pushed a commit that referenced this pull request Dec 2, 2019
Simplify the text about uncaught exceptions in the REPL. PR-URL: #30729 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
targos pushed a commit that referenced this pull request Dec 5, 2019
Simplify the text about uncaught exceptions in the REPL. PR-URL: #30729 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
Simplify the text about uncaught exceptions in the REPL. PR-URL: #30729 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Dec 31, 2019
Simplify the text about uncaught exceptions in the REPL. PR-URL: #30729 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the text about uncaught exceptions in the REPL.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes