lib: Replace Symbol global by the primordials Symbol#30737
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the lib / src 
targos approved these changes Nov 30, 2019
Collaborator
nodejs-github-bot commented Nov 30, 2019
Member
targos commented Nov 30, 2019
Refs: #30697 |
Sebastien-Ahkrinforce-pushed the Symbol branch 2 times, most recently from d356582 to c58ec88Compare
trivikr approved these changes Nov 30, 2019
Sebastien-Ahkrinforce-pushed the Symbol branch 2 times, most recently from bbd0bf2 to c74a4f4Compare
cjihrig approved these changes Nov 30, 2019
Collaborator
nodejs-github-bot commented Nov 30, 2019
BridgeAR approved these changes Dec 2, 2019
targos requested changes Dec 2, 2019
Uh oh!
There was an error while loading. Please reload this page.
targos approved these changes Dec 4, 2019
Collaborator
nodejs-github-bot commented Dec 4, 2019
lpinca approved these changes Dec 5, 2019
Collaborator
nodejs-github-bot commented Dec 5, 2019
targos pushed a commit that referenced this pull request Dec 8, 2019
PR-URL: #30737 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Member
targos commented Dec 8, 2019
Landed in eac3f0a |
targos pushed a commit that referenced this pull request Dec 9, 2019
PR-URL: #30737 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
PR-URL: #30737 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #30737 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update some file to replace Symbol global object to the Symbol primordials.
And i just have created a line in "/lib/.eslintrc.yaml".
Next, just adding : Symbol to every
This task was given to me by @targos thanks ❤️
I hope this new PR will help you :x