lib/v8 Adding TypedArray to primordials#30740
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
Sebastien-Ahkrin commented Nov 30, 2019
Hello, I just have a test who fail this test But i don't know why, someone have an idea ? 😢 thanks and sorry 😄 |
tniessen added the lib / src 
Member
targos commented Dec 4, 2019
This uncovered an existing bug. |
Member
targos commented Dec 9, 2019
Refs: #30697 |
Sebastien-Ahkrinforce-pushed the v8-primordials branch from d53cd70 to c34fa0aCompare
Collaborator
nodejs-github-bot commented Dec 15, 2019
targos approved these changes Dec 15, 2019
jasnell approved these changes Dec 15, 2019
Member
targos commented Dec 16, 2019
Landed in 3743fe1...c88ace4 |
targos pushed a commit that referenced this pull request Dec 16, 2019
PR-URL: #30740 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Dec 16, 2019
PR-URL: #30740 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
PR-URL: #30740 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
PR-URL: #30740 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
PR-URL: #30740 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jan 14, 2020
PR-URL: #30740 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #30740 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #30740 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding every TypedArray to the Primordials global objects.
And update v8 to ensure the usage of these TypedArray from primordials.
Thanks another time @targos
I hope this PR will help you :)