Skip to content

Bugfix/node dir#30747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gengjiawen wants to merge 2 commits into from
Closed

Bugfix/node dir #30747

gengjiawen wants to merge 2 commits into from

Conversation

@gengjiawen
Copy link
Member

@gengjiawengengjiawen commented Dec 1, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 1, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 2, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27263/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 2, 2019
addaleax pushed a commit that referenced this pull request Dec 3, 2019
@gengjiawen@addaleax
src: remove redundant cast in node_dir.cc
1d0c3e3
PR-URL: #30747 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit that referenced this pull request Dec 3, 2019
@gengjiawen@addaleax
src: delete redundant method in node_dir.h
660c433
PR-URL: #30747 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@addaleax
Copy link
Member

addaleax commented Dec 3, 2019

Landed in c9d4949...660c433

@addaleaxaddaleax closed this Dec 3, 2019
@gengjiawengengjiawen deleted the bugfix/node_dir branch December 4, 2019 14:09
targos pushed a commit that referenced this pull request Dec 9, 2019
@gengjiawen@targos
src: remove redundant cast in node_dir.cc
66db874
PR-URL: #30747 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Dec 9, 2019
@gengjiawen@targos
src: delete redundant method in node_dir.h
838ae10
PR-URL: #30747 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 13, 2020
@gengjiawen@targos
src: remove redundant cast in node_dir.cc
9b608e3
PR-URL: #30747 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Jan 13, 2020
@gengjiawen@targos
src: delete redundant method in node_dir.h
85067c1
PR-URL: #30747 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@gengjiawen@BethGriggs
src: remove redundant cast in node_dir.cc
214042c
PR-URL: #30747 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@gengjiawen@BethGriggs
src: delete redundant method in node_dir.h
b233c36
PR-URL: #30747 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@cjihrigcjihrigcjihrig approved these changes

+1 more reviewer

@devnexendevnexendevnexen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gengjiawen@nodejs-github-bot@addaleax@jasnell@cjihrig@devnexen@Trott