readline: eagerly load string_decoder#30807
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was no point in lazy loading the string_decoder, since it would be used in all cases anyway.
nodejs-github-bot added the readline 
addaleax approved these changes Dec 5, 2019
targos approved these changes Dec 5, 2019
ZYSzys approved these changes Dec 5, 2019
Collaborator
nodejs-github-bot commented Dec 5, 2019
Trott approved these changes Dec 5, 2019
lpinca approved these changes Dec 5, 2019
jasnell approved these changes Dec 5, 2019
BridgeAR added the author ready This comment has been minimized.
This comment has been minimized.
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/27385/ ✅ (yellow build with a single Windows flake) |
Trott pushed a commit that referenced this pull request Dec 7, 2019
There was no point in lazy loading the string_decoder, since it would be used in all cases anyway. PR-URL: #30807 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
Trott commented Dec 7, 2019
Landed in 254398a |
targos pushed a commit that referenced this pull request Dec 9, 2019
There was no point in lazy loading the string_decoder, since it would be used in all cases anyway. PR-URL: #30807 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
There was no point in lazy loading the string_decoder, since it would be used in all cases anyway. PR-URL: #30807 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
There was no point in lazy loading the string_decoder, since it would be used in all cases anyway. PR-URL: #30807 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no point in lazy loading the string_decoder, since it
would be used in all cases anyway.
Also refactor
escapeTimeoutto be set once outside the loop.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes