Skip to content

node_crypto: Don't use deprecated OpenSSL APIs#30812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
neheb wants to merge 1 commit into from
Closed

node_crypto: Don't use deprecated OpenSSL APIs #30812

neheb wants to merge 1 commit into from

Conversation

@neheb
Copy link
Contributor

@nehebneheb commented Dec 5, 2019

The extra headers are needed when deprecated APIs are disabled as ssl.h
no longer includes them implicitly.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Dec 5, 2019
@neheb
Copy link
ContributorAuthor

neheb commented Dec 5, 2019

No idea what the failures are about.

@sam-github
Copy link
Contributor

sam-github commented Dec 5, 2019

Click through the details: https://travis-ci.com/nodejs/node/jobs/263603120

@neheb
src: don't use deprecated OpenSSL APIs
0a8f0e3
The extra headers are needed when deprecated APIs are disabled as ssl.h no longer includes them implicitly.
@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 5, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 5, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27365/

@neheb
Copy link
ContributorAuthor

neheb commented Dec 5, 2019

No idea what the issue is this time.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 6, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27373/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 6, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27386/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 6, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27389/

@neheb
Copy link
ContributorAuthor

neheb commented Dec 7, 2019•
edited
Loading

Not related?

14:32:07 not ok 1576 parallel/test-readline-async-iterators-destroy 14:32:07 --- 14:32:07 duration_ms: 2.143 14:32:07 severity: fail 14:32:07 exitcode: 1 14:32:07 stack: |- 14:32:07 events.js:279 14:32:07 throw er; // Unhandled 'error' event 14:32:07 ^ 14:32:07 14:32:07 Error: EBADF: bad file descriptor, read 14:32:07 Emitted 'error' event on ReadStream instance at: 14:32:07 at internal/fs/streams.js:186:12 14:32:07 at FSReqCallback.wrapper [as oncomplete] (fs.js:490:5){14:32:07 errno: -9, 14:32:07 code: 'EBADF', 14:32:07 syscall: 'read' 14:32:07 } 14:51:22 not ok 2661 sequential/test-heap-prof 14:51:22 --- 14:51:22 duration_ms: 120.871 14:51:22 severity: fail 14:51:22 exitcode: -15 14:51:22 stack: |- 14:51:22 timeout 14:51:22 ...

@addaleax
Copy link
Member

addaleax commented Dec 7, 2019

Landed in 4e11920, thanks for the PR!

@addaleaxaddaleax closed this Dec 7, 2019
addaleax pushed a commit that referenced this pull request Dec 7, 2019
@neheb@addaleax
src: don't use deprecated OpenSSL APIs
4e11920
The extra headers are needed when deprecated APIs are disabled as ssl.h no longer includes them implicitly. PR-URL: #30812 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Dec 9, 2019
@neheb@targos
src: don't use deprecated OpenSSL APIs
ccf0917
The extra headers are needed when deprecated APIs are disabled as ssl.h no longer includes them implicitly. PR-URL: #30812 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@neheb@targos
src: don't use deprecated OpenSSL APIs
a5a09ac
The extra headers are needed when deprecated APIs are disabled as ssl.h no longer includes them implicitly. PR-URL: #30812 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@neheb@BethGriggs
src: don't use deprecated OpenSSL APIs
721ebf0
The extra headers are needed when deprecated APIs are disabled as ssl.h no longer includes them implicitly. PR-URL: #30812 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@TrottTrottTrott approved these changes

@cjihrigcjihrigcjihrig approved these changes

+2 more reviewers

@sam-githubsam-githubsam-github approved these changes

@devnexendevnexendevnexen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@neheb@sam-github@nodejs-github-bot@addaleax@jasnell@Trott@cjihrig@devnexen