Skip to content

src: remove unused libraries#30827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
juanarbol wants to merge 1 commit into from
Closed

src: remove unused libraries #30827

juanarbol wants to merge 1 commit into from

Conversation

@juanarbol
Copy link
Member

@juanarboljuanarbol commented Dec 6, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 6, 2019
@trivikrtrivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 7, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27460/

tniessen
tniessen previously approved these changes Dec 8, 2019
View reviewed changes
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27505/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27511/

@TimothyGu
Copy link
Member

TimothyGu commented Dec 9, 2019

Hmm, it appears that at least algorithm and memory are used, since the file explicitly references unique_ptr and find_if. Is there some context I'm missing?

@BridgeARBridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 10, 2019
@juanarbol
Copy link
MemberAuthor

juanarbol commented Dec 11, 2019

Sorry, I was based if it compiles, it works or something, so, I just saw a file where inclues specifies the used methods, I did the same here. Thanks @TimothyGu. I'll spend some time searching why this compiles.

@tniessentniessen dismissed their stale reviewDecember 11, 2019 05:21

Does not apply anymore

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27651/

@Trott
Copy link
Member

Trott commented Dec 14, 2019

The C++ linter is flagging some issues with whitespace. make lint-cpp (or, on Windows, vcbuild lint-cpp) to see the results.

@TrottTrott removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 14, 2019
richardlau
richardlau previously requested changes Dec 14, 2019
View reviewed changes
Copy link
Member

@richardlaurichardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message is no longer accurate.

@richardlaurichardlau dismissed their stale reviewDecember 17, 2019 15:27

Commit message has been updated.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27769/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 17, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 18, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27774/

@BridgeAR
Copy link
Member

BridgeAR commented Dec 20, 2019

Landed in db9539b 🎉

BridgeAR pushed a commit that referenced this pull request Dec 20, 2019
@juanarbol@BridgeAR
src: list used functions on headers
db9539b
PR-URL: #30827 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@juanarbol@BridgeAR
src: list used functions on headers
6b65caf
PR-URL: #30827 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
@BridgeARBridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@juanarbol@targos
src: list used functions on headers
3c63af2
PR-URL: #30827 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@juanarbol@BethGriggs
src: list used functions on headers
f71b09f
PR-URL: #30827 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
@juanarboljuanarbol deleted the cc-unused-libs branch January 19, 2021 16:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@TrottTrottTrott approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@cjihrigcjihrigcjihrig approved these changes

@gengjiawengengjiawengengjiawen approved these changes

@JungMinuJungMinuJungMinu approved these changes

@BridgeARBridgeARBridgeAR approved these changes

@trivikrtrivikrtrivikr approved these changes

@tniessentniessentniessen left review comments

@richardlaurichardlaurichardlau left review comments

+2 more reviewers

@antsmartianantsmartianantsmartian approved these changes

@devnexendevnexendevnexen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

15 participants

@juanarbol@nodejs-github-bot@TimothyGu@Trott@BridgeAR@jasnell@addaleax@antsmartian@cjihrig@tniessen@gengjiawen@devnexen@JungMinu@richardlau@trivikr