doc: update message.url example in http.IncomingMessage#30830
Closed
+17 −39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Update message.url example to use The WHATWG URL API. This is because the old example suggests using deprecated url API. Fixes: nodejs#30048 Refs: https://nodejs.org/dist/latest-v12.x/docs/api/http.html#http_message_url
nodejs-github-bot added doc 
Trott reviewed Dec 7, 2019
Uh oh!
There was an error while loading. Please reload this page.
Trott reviewed Dec 7, 2019
Uh oh!
There was an error while loading. Please reload this page.
Member
Trott commented Dec 7, 2019
@nodejs/http @nodejs/url |
Wrapped at 80 characters and refactored. Fixes: nodejs#30048 Refs: nodejs#30830
lpinca approved these changes Dec 17, 2019
Trott reviewed Dec 18, 2019
Uh oh!
There was an error while loading. Please reload this page.
Trott approved these changes Dec 18, 2019
Co-Authored-By: Rich Trott <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 18, 2019
Update message.url example to use The WHATWG URL API. This is because the old example suggests using deprecated url API. Fixes: nodejs#30048 PR-URL: nodejs#30830 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
Trott commented Dec 18, 2019
Landed in eaf5975. Thanks for the contribution! 🎉 |
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
Update message.url example to use The WHATWG URL API. This is because the old example suggests using deprecated url API. Fixes: #30048 PR-URL: #30830 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
Update message.url example to use The WHATWG URL API. This is because the old example suggests using deprecated url API. Fixes: #30048 PR-URL: #30830 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
Update message.url example to use The WHATWG URL API. This is because the old example suggests using deprecated url API. Fixes: #30048 PR-URL: #30830 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update message.url example to use The WHATWG URL API.
This is because the old example suggests using deprecated url API.
Fixes: #30048
Refs: https://nodejs.org/dist/latest-v12.x/docs/api/http.html#http_message_url
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes