test: wait for stream close before writing to file#30836
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Wait for async operations on a file to finish before writing to it again. This fixes flakiness in parallel/test-readline-async-iterators-destroy. Refs: nodejs#30660
addaleax added the readline 
lpinca approved these changes Dec 7, 2019
cjihrig approved these changes Dec 7, 2019
Collaborator
nodejs-github-bot commented Dec 7, 2019
Trott approved these changes Dec 8, 2019
bnoordhuis approved these changes Dec 8, 2019
Collaborator
nodejs-github-bot commented Dec 10, 2019
addaleax added the author ready Collaborator
nodejs-github-bot commented Dec 10, 2019
Collaborator
nodejs-github-bot commented Dec 10, 2019
addaleax added a commit that referenced this pull request Dec 10, 2019
Wait for async operations on a file to finish before writing to it again. This fixes flakiness in parallel/test-readline-async-iterators-destroy. PR-URL: #30836Fixes: #30660 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
MemberAuthor
addaleax commented Dec 10, 2019
Landed in b7d87e3 |
targos pushed a commit that referenced this pull request Dec 11, 2019
Wait for async operations on a file to finish before writing to it again. This fixes flakiness in parallel/test-readline-async-iterators-destroy. PR-URL: #30836Fixes: #30660 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
Wait for async operations on a file to finish before writing to it again. This fixes flakiness in parallel/test-readline-async-iterators-destroy. PR-URL: #30836Fixes: #30660 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
Wait for async operations on a file to finish before writing to it again. This fixes flakiness in parallel/test-readline-async-iterators-destroy. PR-URL: #30836Fixes: #30660 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait for async operations on a file to finish before writing to it
again.
This fixes flakiness in parallel/test-readline-async-iterators-destroy.
Fixes: #30660
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes