build: fix missing arch suffix in binary tar name#30877
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the build 
legendecas changed the title 
devnexen approved these changes Dec 10, 2019
MemberAuthor
legendecas commented Dec 13, 2019
@nodejs/build wondering if this misaligned |
richardlau approved these changes Dec 13, 2019
Member
richardlau left a comment
richardlau left a comment There was a problem hiding this comment.
Good catch! I'm assuming the release jobs (I can't see them) have the ARCH environment variable set, which is why this wasn't spotted before or cause issues for the releases.
richardlau added the author ready 
Collaborator
nodejs-github-bot commented Dec 13, 2019
Member
richardlau commented Dec 13, 2019
cc @nodejs/build-files |
Trott approved these changes Dec 13, 2019
Collaborator
nodejs-github-bot commented Dec 13, 2019
Collaborator
nodejs-github-bot commented Dec 13, 2019
Trott pushed a commit that referenced this pull request Dec 14, 2019
PR-URL: #30877 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
Trott commented Dec 14, 2019
Landed in 1807c3e |
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
PR-URL: #30877 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Member
rvagg commented Dec 20, 2019
👍 I've been very careful to make sure to be explicit with |
targos pushed a commit that referenced this pull request Jan 14, 2020
PR-URL: #30877 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #30877 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes