Skip to content

Conversation

@Trott
Copy link
Member

Add information about what it means when colorMode is set to false.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added console Issues and PRs related to the console subsystem. doc Issues and PRs related to the documentations. labels Dec 10, 2019
@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 10, 2019
Add information about what it means when colorMode is set to false. PR-URL: nodejs#30887 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@TrottTrott merged commit 973b5c0 into nodejs:masterDec 12, 2019
@Trott
Copy link
MemberAuthor

Landed in 973b5c0

MylesBorins pushed a commit that referenced this pull request Dec 13, 2019
Add information about what it means when colorMode is set to false. PR-URL: #30887 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 13, 2019
targos pushed a commit that referenced this pull request Jan 14, 2020
Add information about what it means when colorMode is set to false. PR-URL: #30887 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@targostargos mentioned this pull request Jan 15, 2020
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
Add information about what it means when colorMode is set to false. PR-URL: #30887 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
@TrottTrott deleted the colormode2 branch April 14, 2022 11:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.consoleIssues and PRs related to the console subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@lpinca@cjihrig@BridgeAR@nodejs-github-bot