doc: improve doc writable streams: 'finish' event#30889
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
doc change for stream.md that 'finish' event should be before writer.end fixes: #30759
nodejs-github-bot added doc 
ContributorAuthor
dev-script commented Dec 10, 2019
@GrosSacASac please review. |
Member
I'm not sure I understand the purpose here? |
Contributor
GrosSacASac commented Dec 11, 2019
Yes to make it easier to understand and also to make it easier to switch to implementation that don't rely on this hidden gimmick. |
BridgeAR approved these changes Dec 11, 2019
Trott added the author ready 
Trott approved these changes Dec 13, 2019
Member
Trott commented Dec 13, 2019
Landed in 08728a1 |
Trott pushed a commit that referenced this pull request Dec 13, 2019
doc change for stream.md that 'finish' event should be before writer.end fixes: #30759 PR-URL: #30889Fixes: #30759 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
doc change for stream.md that 'finish' event should be before writer.end fixes: #30759 PR-URL: #30889Fixes: #30759 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
doc change for stream.md that 'finish' event should be before writer.end fixes: #30759 PR-URL: #30889Fixes: #30759 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
doc change for stream.md that 'finish' event should be before writer.end fixes: #30759 PR-URL: #30889Fixes: #30759 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc change for stream.md that 'finish' event should be before
writer.end
fixes: #30759
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes