Skip to content

Conversation

@Sebastien-Ahkrin
Copy link
Contributor

This time i just replaced every Symboll.toStringTag by SymbolToStringTag in the lig/* folder.
I had to import SymbolToStringTag like that

const{ SymbolToStringTag,}=primordials;

I hope this pull request will help you ! :P

@nodejs-github-botnodejs-github-bot added encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. util Issues and PRs related to the built-in util module. labels Dec 11, 2019
@Sebastien-Ahkrin
Copy link
ContributorAuthor

Refs: #30697

@targostargos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2019
@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member

Landed in ac1cc5c

@TrottTrott closed this Dec 13, 2019
Trott pushed a commit that referenced this pull request Dec 13, 2019
PR-URL: #30908 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
PR-URL: #30908 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 17, 2019
targos pushed a commit that referenced this pull request Jan 14, 2020
PR-URL: #30908 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@targostargos mentioned this pull request Jan 15, 2020
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #30908 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.encodingIssues and PRs related to the TextEncoder and TextDecoder APIs.utilIssues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Sebastien-Ahkrin@nodejs-github-bot@Trott@addaleax@targos@cjihrig@BridgeAR