test: load common.js to test for global leaks#3095
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
common.js contains code that checks for variables leaking into the global namespace. Load common.js in all tests that do not intentionally leak variables.
MemberAuthor
Trott commented Sep 27, 2015
Contributor
brendanashworth commented Sep 28, 2015
It'd be cool if we could get a linter rule for this, that way reviewers can't miss it on new tests. |
Contributor
Fishrock123 commented Oct 1, 2015
+1 linter rule. |
Contributor
Fishrock123 commented Oct 1, 2015
Also lgtm |
Contributor
thefourtheye commented Oct 1, 2015
LGTM |
MemberAuthor
Trott commented Oct 2, 2015
I've written an eslint rule for this and will submit it with a subsequent pull request. Thanks for the suggestion! |
MemberAuthor
Trott commented Oct 2, 2015
Landed in 02fe821 |
Trott added a commit that referenced this pull request Oct 2, 2015
common.js contains code that checks for variables leaking into the global namespace. Load common.js in all tests that do not intentionally leak variables. PR-URL: #3095 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Trott added a commit that referenced this pull request Oct 2, 2015
common.js contains code that checks for variables leaking into the global namespace. Load common.js in all tests that do not intentionally leak variables. PR-URL: #3095 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common.js contains code that checks for variables leaking into the
global namespace. Load common.js in all tests that do not
intentionally leak variables.