Skip to content

stream: use for...of#30960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
trivikr wants to merge 3 commits into from
Closed

stream: use for...of #30960

trivikr wants to merge 3 commits into from

Conversation

@trivikr
Copy link
Member

@trivikrtrivikr commented Dec 14, 2019

Searched for regular expression for \([^\.]*.length in lib and made changes in _stream_* files

Refs: #30910 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Dec 14, 2019
@richardlau
Copy link
Member

richardlau commented Dec 14, 2019

I think these files are used in https://github.com/nodejs/readable-stream and still support older versions of Node.js so the performance would need to be checked on those?

cc @nodejs/streams

mcollina
mcollina approved these changes Dec 14, 2019
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as they do not land on 10 (that's where readable-stream is currently cut from)

@mcollina
Copy link
Member

mcollina commented Dec 14, 2019

Those do not sit in a hot path, as far as I know.

@trivikrtrivikr mentioned this pull request Dec 14, 2019
Closed
3 tasks
@trivikrtrivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 14, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27680/

soar-beep added a commit to soar-beep/node that referenced this pull request Dec 16, 2019
@soar-beep
assert: use for...of
56a8b7d
Refs: nodejs#30960
@soar-beepsoar-beep mentioned this pull request Dec 16, 2019
Closed
2 tasks
trivikr added a commit that referenced this pull request Dec 16, 2019
@trivikr
stream: use for...of
ce49f90
PR-URL: #30960 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
@trivikr
Copy link
MemberAuthor

trivikr commented Dec 16, 2019

Landed in ce49f90

@trivikrtrivikr closed this Dec 16, 2019
@trivikrtrivikr deleted the use-for-of-stream branch December 16, 2019 23:21
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@trivikr@MylesBorins
stream: use for...of
5ca29d8
PR-URL: #30960 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 17, 2019
Merged
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 18, 2019
@soar-beep@Trott
assert: use for...of
145116b
Refs: nodejs#30960 PR-URL: nodejs#30983 Refs: nodejs#30960 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@trivikrtrivikr mentioned this pull request Dec 24, 2019
Closed
2 tasks
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@soar-beep@BridgeAR
assert: use for...of
f8aa365
Refs: #30960 PR-URL: #30983 Refs: #30960 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jan 14, 2020
@trivikr@targos
stream: use for...of
f6acf9a
PR-URL: #30960 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jan 14, 2020
@soar-beep@targos
assert: use for...of
9da5444
Refs: #30960 PR-URL: #30983 Refs: #30960 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@trivikr@BethGriggs
stream: use for...of
3872a02
PR-URL: #30960 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@soar-beep@BethGriggs
assert: use for...of
6909e3e
Refs: #30960 PR-URL: #30983 Refs: #30960 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@jasnelljasnelljasnell approved these changes

@TrottTrottTrott approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@lpincalpincalpinca approved these changes

@targostargostargos approved these changes

@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@trivikr@richardlau@mcollina@nodejs-github-bot@jasnell@Trott@addaleax@lpinca@targos@BridgeAR